Midnight Observer throws error on start-up

[philippkolbe]

The midnight_observer throws an error on the first loading of the progressions because the userId is not loaded yet at that point in time.
Somehow we have to wait for the userId to be loaded before instantiating the observer.
Or we catch the error and add a call to loadProgressions once the user is loaded...

Checklist

• Modify app/lib/observers/midnight_observer.dart ✓ 510c08c Edit
• Running GitHub Actions for app/lib/observers/midnight_observer.dart ✓ Edit

[sweep-ai-deprecated]

🚀 Here's the PR! #76

See Sweep's progress at the progress dashboard!

⚡ Sweep Basic Tier: I'm using GPT-4. You have 4 GPT-4 tickets left for the month and 2 for the day. (tracking ID: fe063ddfc3)

For more GPT-4 tickets, visit our payment portal. For a one week free trial, try Sweep Pro (unlimited GPT-4 tickets).

Install Sweep Configs: Pull Request

---

Actions (click)

• ↻ Restart Sweep

Sandbox Execution ✓

Here are the sandbox execution logs prior to making any changes:

Sandbox logs for a5b7e40

Checking app/lib/observers/midnight_observer.dart for syntax errors... ✅ app/lib/observers/midnight_observer.dart has no syntax errors! 1/1 ✓

Checking app/lib/observers/midnight_observer.dart for syntax errors...
✅ app/lib/observers/midnight_observer.dart has no syntax errors!

Sandbox passed on the latest main, so sandbox checks will be enabled for this issue.

---

Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I think are relevant in decreasing order of relevance (click to expand). If some file is missing from here, you can mention the path in the ticket description.

digital_journal/app/lib/observers/midnight_observer.dart

Lines 10 to 56 in a5b7e40

	void initializeMidnightObserver(WidgetRef ref) {
	final authStream = ref.read(authRepositoryProvider).authStateChangesStream;
	StreamSubscription? sub;
	authStream.listen((newUser) {
	sub?.cancel();
	if (newUser != null) {
	sub = currentDayStream.listen((DateTime currentDay) async {
	final progressRepository = ref.read(progressRepositoryProvider);
	List<ProgressObj> allProgressObjs = await progressRepository.readAllProgressions(newUser.uid);
	final List<ProgressObj> newProgressObjs = [];
	for (var progressObj in allProgressObjs) {
	if (isProgressActive(progressObj, currentDay)) {
	final daysSinceStart = currentDay.difference(progressObj.startDate).inDays;
	final hasBeenCompleted = progressObj.hasBeenCompletedToday;
	final daysCompleted = progressObj.daysCompleted;
	final isNewDay = daysSinceStart > daysCompleted
	|| (daysCompleted == daysSinceStart && hasBeenCompleted);
	if (isNewDay) {
	newProgressObjs.add(progressObj.copyWith(
	daysCompleted: daysSinceStart,
	hasBeenCompletedToday: false,
	streak: isNewDay && !hasBeenCompleted ? 0 : progressObj.streak,
	));
	}
	}
	}
	await Future.wait(newProgressObjs.map(
	(updatedProgressObj) => progressRepository.updateProgress(
	newUser.uid,
	updatedProgressObj,
	),
	));
	final controller = ref.read(progressControllerProvider.notifier);
	// TODO: This throws on start because user is not loaded
	await controller.loadProgressions();
	});
	}

digital_journal/app/lib/providers/prompts_providers.dart

Lines 28 to 75 in a5b7e40

	final goalPromptsProvider = Provider<Map<ChatJournalType, String>>((ref) {
	final mood = ref.watch(moodStateProvider);
	final reflectingOnChallenge = ref.watch(reflectingOnChallengeProvider);
	final challenges = ref.watch(progressControllerProvider).valueOrNull;
	// load attributes (likes, dislikes, goals, values, fears)
	// load information from memory
	// load current daytime (morning, afternoon, evening, night), day of week, date
	// Define the hard-coded prompts for each chat journal type
	final personalityPrompt = ref.watch(selectedPersonalityProvider)?.prompt ?? getStandardPersonalityPrompt();
	return {
	ChatJournalType.standard: '''
	$personalityPrompt. You don't have to introduce yourself. By asking simple, non-intrusive questions, you empower users to delve deeper into their thoughts. Always ask one question at a time and await the users answer before asking more questions.
	Your first answer should be one simple question. ${mood != null ? 'The user entered that he is feeling ${moodToString(mood)}. ' : ''}Remember to stick to your personality. Be very concise in answers.''',
	ChatJournalType.reflection: '''
	You are a friendly and motivating journaling companion within an app. The chat users now you already - you don’t have to introduce yourself. As users chat with you, you provide guidance for journaling and self-reflection.
	Help them reflect about their feelings and progress on challenges. Always ask one question at a time and await the users answer before asking more questions. Your first answer should be one simple question.
	The user just completed a daily challenge named "$reflectingOnChallenge". ${mood != null ? 'They said that now they feel ${moodToString(mood)}. ' : ''}
	Remember to maintain a quiet and supportive presence, akin to a trusted journal. Be very concise in answers.''',
	ChatJournalType.goalDiscovery: '''
	You are a friendly and motivating journaling companion within an app. The chat users now you already - you don’t have to introduce yourself. As users chat with you, you provide guidance for journaling and self-reflection.
	Your goal is to help users explore their emotions and personal development. By asking simple, non-intrusive questions, you empower users to delve deeper into their thoughts. Always ask one question at a time and await the users answer before asking more questions.
	Your first answer should be one simple question. Once you identify a SMART goal with the user, you suggest specific daily challenges that align with their aspirations. Ask at least 3 questions one after another before you start identifying goals. The user is currently doing the challenges ${challenges != null ? challenges.map((c) => c.title).join(', ') : ''}.
	Remember to maintain a quiet and supportive presence, akin to a trusted journal. Be very concise in answers.''',
	};
	});
	String getStandardPersonalityPrompt() {
	return '''You are a friendly and motivating journaling companion within an app. As users chat with you, you provide guidance for journaling and self-reflection. Your goal is to help users explore their emotions and personal development. Remember to maintain a quiet and supportive presence, akin to a trusted journal.''';
	}
	final generalPromptsProvider = Provider<Map<GeneralPrompts, String>>((ref) {
	return {
	GeneralPrompts.conversationSummary: '''
	As a summarizer within a journaling app, continuously summarize the ongoing conversation for other GPT-3.5 instances. The goal is to include all relevant information regarding the user's fears, goals, values, likes, and dislikes. The summary's readability for humans is not a priority; it's solely for other AI instances to analyze. Prioritize maximum brevity without compromising completeness; shorter summaries are preferred when the information is irrelevant.
	If the user provides a summary of the conversation, ensure that the newly created summary includes all relevant information from the user's summary. No need to mention that summarized information was provided. Focus solely on the content's relevance.
	''', // one could tell the bot how many tokens the conversation is supposed to have...
	GeneralPrompts.summarizeChatMessage: '''Summarize our conversation up to the message before this one. You're answer does not have to be human readable so be as concise as possible.''',
	};
	});
	final summaryPromptProvider = Provider<AsyncValue<String?>>((ref) {
	final asyncSummary = ref.watch(summaryProvider);
	return asyncSummary.whenData((summary) => summary != null
	? createPreviousSummaryUserMessage(summary.content)
	: null);

---

Step 2: ⌨️ Coding

• Modify app/lib/observers/midnight_observer.dart ✓ 510c08c Edit

Modify app/lib/observers/midnight_observer.dart with contents:
• In the `initializeMidnightObserver` function, add a check for the user's existence before trying to load the progressions. This can be done by adding an if statement that checks if `newUser` is not null before proceeding with the rest of the function.
• If `newUser` is null, the function should wait until `newUser` is not null before proceeding. This can be achieved by adding a while loop that continues as long as `newUser` is null. Inside the loop, use the `await` keyword to pause execution of the function until the next event loop iteration, giving the `authStateChangesStream` a chance to update `newUser`.
• After the while loop, proceed with the rest of the function as before. This ensures that the progressions are only loaded when the user is loaded, preventing the error from occurring.

--- 
+++ 
@@ -12,7 +12,12 @@
   final authStream = ref.read(authRepositoryProvider).authStateChangesStream;
 
   StreamSubscription? sub;
-  authStream.listen((newUser) {
+  authStream.listen((newUser) async { // Add async to allow use of await
+  while (newUser == null) {
+    await Future.delayed(Duration.zero);
+  }
+
+  if (newUser != null) {
     sub?.cancel();
 
     if (newUser != null) {

• Running GitHub Actions for app/lib/observers/midnight_observer.dart ✓ Edit

Check app/lib/observers/midnight_observer.dart with contents:

Ran GitHub Actions for 510c08cc8e15fa4a049fc2cfacc6fc3803e5eee9:

---

Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/midnight_observer_throws_error_on_startu.

---

🎉 Latest improvements to Sweep:

• We just released a dashboard to track Sweep's progress on your issue in real-time, showing every stage of the process – from search to planning and coding.
• Sweep uses OpenAI's latest Assistant API to plan code changes and modify code! This is 3x faster and significantly more reliable as it allows Sweep to edit code and validate the changes in tight iterations, the same way as a human would.
• Try using the GitHub issues extension to create Sweep issues directly from your editor! GitHub Issues and Pull Requests.

---

💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request.
^{Join Our Discord}