Skip to content

Area beginWindowMove beginWindowResize#105

Open
mischnic wants to merge 5 commits into
0_3_0from
area-begin
Open

Area beginWindowMove beginWindowResize#105
mischnic wants to merge 5 commits into
0_3_0from
area-begin

Conversation

@mischnic

@mischnic mischnic commented May 4, 2018

Copy link
Copy Markdown
Collaborator

Closes #99

@mischnic mischnic changed the base branch from master to 0_3_0 May 4, 2018 09:57
mischnic
mischnic commented May 4, 2018
View reviewed changes
Comment thread src/UiArea/UiAreaHandler.cc
void MouseEvent(UiAreaHandler *self, uiArea *area, uiAreaMouseEvent *event) {
UiAreaMouseEvent *ev = new UiAreaMouseEvent(event);
(*(self->mouseEvent))(controlsMap[uiControl(area)], ev);
(*(self->mouseEvent))((UiArea *)controlsMap[uiControl(area)], ev);

@mischnic mischnic May 4, 2018

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the event callbacks got a UiControl object (not UiArea)

@parro-it

parro-it commented May 4, 2018

Copy link
Copy Markdown
Owner

Looks good!
BTW, do you know why libui implemented this features specifically for Area?

@mischnic

mischnic commented May 4, 2018

Copy link
Copy Markdown
Collaborator Author

Maybe for a borderless window to implement a completely own ui with a menubar?

@parro-it

parro-it commented May 4, 2018

Copy link
Copy Markdown
Owner

Works on High Sierra:

mag-04-2018 12-14-11

Will you add an example of resize to?

@mischnic

mischnic commented May 4, 2018 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Will you add an example of resize to?

Added, please test it on High Sierra. Doesn't work for me: andlabs/libui#357

@parro-it

parro-it commented Jun 1, 2018

Copy link
Copy Markdown
Owner

Added, please test it on High Sierra.

Doesn't work on high sierra too...

@parro-it

parro-it commented Jun 1, 2018

Copy link
Copy Markdown
Owner

Since the resize feature is blocked by the libui issue, I purpose to move it to version 0_4_0 and merge only the move feature here.

@mischnic

mischnic commented Jun 1, 2018

Copy link
Copy Markdown
Collaborator Author

Since the resize feature is blocked by the libui issue, I purpose to move it to version 0_4_0 and merge only the move feature here.

Here is the PR to fix this: andlabs/libui#385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mischnic @parro-it