Map elements and "current contact" bottom sheet clip under app bar and navigation bar

[otwacam]

Version affected: 2.5.5

When on the map screen multiple elements are clipping under the app bar and navigation bar (if enabled) for vertical and horizontal orientation. Below is a non-exhaustive list of the issues. Images attached show more of the issues.

For vertical orientation:
The compass button is always under the app bar and is barely visible.

If the navigation bar is enabled:
The "my location" FAB is partially obscured by the nav bar
The "contact peek" bottom sheet is partially obscured by the nav bar and also obscures part of the "my location" FAB
The contact bottom sheet "share" button is mostly obscured by the nav bar
The copyright text for Openstreetmap is completely obscured by the nav bar

Vertical

Horizontal

[AvikMakwana]

Hi, I’d like to work on this issue.

I’m planning to keep the fix focused on the current master implementation by applying the proper system-bar/window insets to the existing map overlays, FABs and contact bottom sheet in both portrait and landscape.

I noticed the open Compose migration PR also touches MapActivity, but since that is a much broader change, I’d avoid depending on it and submit a small standalone fix.

Does that direction sound good?

[growse]

Please do - I'd work on the 2.6.0-beta1 as a latest base, as we're just getting bugfixes in now before 2.6.0.