OptionsContract.isSafe(uint256,uint256) (OptionsContract.sol#847-885) performs a multiplication on the result of a division

[OptionsContract.isSafe(uint256,uint256)](https://github.com/opynfinance/OptionsProtocol/blob/dev/contracts/OptionsContract.sol#L847-L885) performs a multiplication on the result of a division:
	-[rightSideVal = (collateralAmt.mul(collateralToEthPrice)).div(strikeToEthPrice)](https://github.com/opynfinance/OptionsProtocol/blob/dev/contracts/OptionsContract.sol#L868-L870)
	-[stillSafe = leftSideVal <= rightSideVal.mul(10 ** exp)](https://github.com/opynfinance/OptionsProtocol/blob/dev/contracts/OptionsContract.sol#L881)

Consider ordering multiplication prior division.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

OptionsContract.isSafe(uint256,uint256) (OptionsContract.sol#847-885) performs a multiplication on the result of a division #153

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Uh oh!

OptionsContract.isSafe(uint256,uint256) (OptionsContract.sol#847-885) performs a multiplication on the result of a division #153

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions