Skip to content

OptionsContract.calculateOTokens(uint256,OptionsContract.Number) (OptionsContract.sol#908-943) performs a multiplication on the result of a division #152

Open
Open
OptionsContract.calculateOTokens(uint256,OptionsContract.Number) (OptionsContract.sol#908-943) performs a multiplication on the result of a division#152
Labels
cryticCreate by crytic security report

Description

@ghost
ghost
opened on Aug 11, 2020

OptionsContract.calculateOTokens(uint256,OptionsContract.Number) performs a multiplication on the result of a division:
-numeratorVal = (collateralAmt.mul(collateralToEthPrice)).div(strikeToEthPrice)
-numOptions = numeratorVal.mul(10 ** exp).div(denomVal)

Consider ordering multiplication prior division.

Metadata

Metadata

Assignees

No one assigned

    Labels

    cryticCreate by crytic security report

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions