[AI-FSSDK] [FSSDK-12670] Block ODP identify events with single identifier#409
Open
jaeopt wants to merge 1 commit into
Open
[AI-FSSDK] [FSSDK-12670] Block ODP identify events with single identifier#409jaeopt wants to merge 1 commit into
jaeopt wants to merge 1 commit into
Conversation
Add count check in IdentifyUser to filter out empty identifier values and require 2+ valid identifiers before dispatching. Server-side C# SDK only has fs_user_id (no VUID), so identify events will be correctly skipped with a debug log message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Block ODP identify events when only a single valid identifier is provided. Identify events exist to link multiple user identifiers together; sending them with a single identifier provides no value and wastes network calls.
Jira: FSSDK-12670
Changes
OptimizelySDK/Odp/OdpEventManager.csIdentifyUserTests (
OdpEventManagerTests.cs)ShouldLogWhenOdpNotIntegratedAndIdentifyUserCalledto expect 2 ODP_NOT_INTEGRATED logs (instead of 3) since IdentifyUser now returns before reaching SendEventShouldPrepareCorrectPayloadForIdentifyUserwithShouldNotSendIdentifyEventWithSingleIdentifierto verify single-identifier identify events are blockedNotes
IdentifyUseralways has a singlefs_user_ididentifier and identify events will be correctly skippedIdentifyUser(string userId)API is unchanged for backward compatibility