From beadd4f40003b39db550817c7e1cc9c4d1e78542 Mon Sep 17 00:00:00 2001 From: Andrea Louis <76847598+alouis-jpg@users.noreply.github.com> Date: Wed, 3 Jul 2024 18:11:33 +0200 Subject: [PATCH] fixed r3f example - runtime.update params updated and resetTransform applied --- examples/r3f/src/index.tsx | 47 ++++++++++++++----------- examples/r3f/src/loader-3dtiles-r3f.tsx | 3 +- 2 files changed, 27 insertions(+), 23 deletions(-) diff --git a/examples/r3f/src/index.tsx b/examples/r3f/src/index.tsx index 1cb26d84..3ffeaebb 100644 --- a/examples/r3f/src/index.tsx +++ b/examples/r3f/src/index.tsx @@ -1,37 +1,42 @@ -import * as ReactDOM from 'react-dom/client' -import { useState, useRef, Suspense } from 'react' -import { Canvas } from '@react-three/fiber' -import { PerspectiveCamera, OrbitControls } from '@react-three/drei' +import * as ReactDOM from 'react-dom/client'; +import { useState, useRef, Suspense } from 'react'; +import { Canvas } from '@react-three/fiber'; +import { PerspectiveCamera, OrbitControls } from '@react-three/drei'; import { ErrorBoundary } from 'react-error-boundary'; -import { Matrix4, Euler } from 'three' +import { Matrix4, Euler } from 'three'; -import { Loader3DTilesR3FAsset } from './loader-3dtiles-r3f' +import { Loader3DTilesR3FAsset } from './loader-3dtiles-r3f'; function App() { const camera = useRef(null); return (
- + - ( - - - - - )}> - ( - + - }> + )} + > + + + + + } + > @@ -39,7 +44,7 @@ function App() {
- ) + ); } const root = ReactDOM.createRoot(document.getElementById('root')); diff --git a/examples/r3f/src/loader-3dtiles-r3f.tsx b/examples/r3f/src/loader-3dtiles-r3f.tsx index 5797a5e2..f3b2de7e 100644 --- a/examples/r3f/src/loader-3dtiles-r3f.tsx +++ b/examples/r3f/src/loader-3dtiles-r3f.tsx @@ -16,7 +16,6 @@ class Loader3DTilesBridge extends Loader { onLoad(result); } catch(e) { - console.log("Error loading 3d tiles!", e); onError(e); } } @@ -44,7 +43,7 @@ function Loader3DTilesR3FAsset(props) { }) useFrame(({ size, camera }, dt) => { - runtime.update(dt, size.height, camera); + runtime.update(dt, camera); }); return (