Aio image dual arch#1
Merged
Merged
Conversation
replaced wget with curl and removed ping util
nhalstead
force-pushed
the
aio-image-dual-arch
branch
from
bf85810 to
969d5cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructure to use an all-in-one Dockerfile and set ARGs to set the base image (as all of the layers are the same).
This will build proper support for ARM and reduce build time. This adds a bit of complexity to prod builds, as it requires retagging the images from their
sha256:tags to their properphp-versiontags, but it's the only way to get fast builds and keep a single manifest tag for both arch types.provenance: mode=minThe build matrix settings keep parity with the current file-based build.