Uptime string fails parsing if missing seconds

[tyler-8]

Environment

• Python version: 3.12
• netutils version: 1.12.0

Expected Behavior

uptime_string_to_seconds("2w1d") would result in an integer of the number of seconds.

Observed Behavior

ValueError: Unable to parse uptime string.

Steps to Reproduce

1. In a Python shell, from netutils.time import uptime_string_to_seconds
2. Call function with a string argument that does not contain a seconds value (such as "2w1d")
3. Observe exception

The closest matching regex parser assumes every uptime string will contain a 'seconds' value, which isn't always true. For example; in the up-time attribute of a NETCONF query to a Cisco IOS-XE device to show BGP neighbors.

[itdependsnetworks]

Can you provide the perceived rules you see in NETCONF query to a Cisco IOS-XE device to show BGP neighbors ? Meaning, is it always just day level details? Would year show up as well? Month? etc...

Should be super simple to update regex to include it here once understood:

netutils/netutils/constants.py

Lines 406 to 420 in 547c342

	UPTIME_REGEX_PATTERNS = [
	(
	r"((?P<years>\d+) year(s)?,\s+)?((?P<weeks>\d+) week(s)?,\s+)?"
	r"((?P<days>\d+) day(s)?,\s+)?((?P<hours>\d+) "
	r"hour(s)?,\s+)?((?P<minutes>\d+) minute(s)?)"
	),
	(
	r"((?P<days>\d+) day(s)?,\s+)?"
	r"((?P<hours>\d+)):((?P<minutes>\d+)):((?P<seconds>\d+))" # pylint: disable=implicit-str-concat
	),
	(
	r"(((?P<years>\d+)y)?(?P<weeks>\d+)w)?((?P<days>\d+)d)?((?P<hours>\d+)h)?"
	r"((?P<minutes>\d+)m)?((?P<seconds>\d+)s)"
	), # pylint: disable=implicit-str-concat
	]

[tyler-8]

That's a good question. I'll comb through some more outputs to see if there's a "rollover" that happens where seconds are no longer included.

Also can we talk about how a structured data API like NETCONF is still providing a human readable timestamp instead of a raw number value or other machine-friendly timestamp? 😞