From 114f73a3919d3e74c6386e013a1031903545656a Mon Sep 17 00:00:00 2001 From: Fabrizio2210 <34220075+fabrizio2210@users.noreply.github.com> Date: Thu, 16 Jul 2026 16:08:18 +0200 Subject: [PATCH 1/2] Revert "Run Slurm script unit tests in CI" --- .github/workflows/one_job.yml | 15 --------------- Makefile | 24 ------------------------ 2 files changed, 39 deletions(-) diff --git a/.github/workflows/one_job.yml b/.github/workflows/one_job.yml index d6062c552..6d95076cb 100644 --- a/.github/workflows/one_job.yml +++ b/.github/workflows/one_job.yml @@ -204,20 +204,6 @@ jobs: fi go build "${packages[@]}" - test-python: - needs: [changes, authorize] - if: needs.changes.outputs.should_build == 'true' - runs-on: ubuntu-24.04 - - steps: - - name: Checkout repository - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 - with: - ref: ${{ github.event.pull_request.head.sha }} - - - name: Test Python - run: make test-python - build-soperator-images: needs: - changes @@ -860,7 +846,6 @@ jobs: - pre-build - lint - build-e2e - - test-python - build-slurm-images - build-soperator-images - manifest-populate-jail diff --git a/Makefile b/Makefile index 900079306..e5d6f5044 100644 --- a/Makefile +++ b/Makefile @@ -119,30 +119,6 @@ vet: ## Run go vet against code. test: manifests generate fmt vet envtest ## Run tests. go test ./... -.PHONY: test-python -test-python: ## Run all Python unit tests. - @found=false; \ - while IFS= read -r -d '' test_file; do \ - found=true; \ - test_dir=$$(dirname "$$test_file"); \ - test_pattern=$$(basename "$$test_file"); \ - echo "Running Python unit tests in $$test_file"; \ - PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover \ - -s "$$test_dir" \ - -p "$$test_pattern" \ - -v; \ - done < <(find . \ - -type d \( \ - -name .git -o \ - -name .venv -o \ - -name venv -o \ - -name __pycache__ \ - \) -prune -o \ - -type f \( -name '*_test.py' -o -name 'test_*.py' \) -print0); \ - if [ "$$found" = false ]; then \ - echo "No Python unit tests found; skipping."; \ - fi - .PHONY: test-coverage test-coverage: manifests generate fmt vet envtest ## Run tests and generate test coverage. go test ./... -coverprofile cover.out From b1518aebb40758aaa2d4c6b7f4a5be9366598e46 Mon Sep 17 00:00:00 2001 From: Fabrizio Waldner Date: Thu, 16 Jul 2026 16:25:22 +0200 Subject: [PATCH 2/2] Keep temporary test-python compatibility target --- Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Makefile b/Makefile index e5d6f5044..af189e2f4 100644 --- a/Makefile +++ b/Makefile @@ -119,6 +119,10 @@ vet: ## Run go vet against code. test: manifests generate fmt vet envtest ## Run tests. go test ./... +.PHONY: test-python +test-python: ## Temporarily retained while removing Python unit tests from CI. + @echo "Python unit tests are disabled in CI." + .PHONY: test-coverage test-coverage: manifests generate fmt vet envtest ## Run tests and generate test coverage. go test ./... -coverprofile cover.out