Use SequencePoint when reporting missing resource errors#8
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
Co-authored-by: mrpmorris <[email protected]>
Copilot
AI
changed the title
[WIP] Fix issue 7
Use SequencePoint when reporting missing resource errors
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a required resource name is missing from the resource file,
WriteErrorwas called with only the message string, losing source location context. Fody'sWriteError(string, SequencePoint)overload associates the error with a specific point in source, enabling IDEs and build output to navigate directly to the offending member.Changes
Dictionary<string, SequencePoint?>replacesHashSet<string>forrequiredResourceNames— maps each resource name to the sequence point of the member that requires itGetSequencePoint(IMemberDefinition)— new helper that extracts the firstSequencePointfrom a property's getter/setter debug info; returnsnullfor fields or when no PDB data is presentUpdateValidationAttribute— now receives theIMemberDefinitionand stores the extractedSequencePointalongside the resource nameEnsureRequiredResourceNamesExistInResourceFile— callsWriteError(message, sequencePoint)when a sequence point is available, falls back toWriteError(message)otherwise🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.