Validate manually-configured ErrorMessageResourceType+Name against the specified resource type#6
Draft
Copilot wants to merge 2 commits into
Draft
Validate manually-configured ErrorMessageResourceType+Name against the specified resource type#6Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…ame against specified resource type Co-authored-by: mrpmorris <[email protected]>
Copilot
AI
changed the title
[WIP] Fix issue and add unit test
Validate manually-configured ErrorMessageResourceType+Name against the specified resource type
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user explicitly sets both
ErrorMessageResourceTypeandErrorMessageResourceNameon a validation attribute, the weaver silently skipped all validation — meaning a missing resource key would not be caught at build time. Any validation that did occur would have checked against the global resource type rather than the specified one.Changes
ModuleWeaver.cs:ScanMembernow also collects attributes that have bothErrorMessageResourceType(non-null) andErrorMessageResourceNameexplicitly set.ProcessClassesvalidates these manually-configured pairs against their specified type (grouped byTypeReference.FullName) rather than the global type. Attributes withErrorMessageset are still skipped.WeaverExecutor.cs: Added optionaladditionalEmbeddedResourceFilesparameter (IReadOnlyDictionary<string, IEnumerable<KeyValuePair<string, string?>>>) to support embedding multiple resource files in test assemblies.AutoLocalizeValidationAttributesAttributeTests.cs: Two new tests covering the scenario with a non-globalOtherStringsresource type:UnitTest.OtherStrings, notUnitTest.AppStrings📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.