Virtual envs in the workspace are treated as user source

[rchiodo]

I have a workspace folder like so:

• root
  • venv1
  • venv2
  • test.py

When opening the folder, it analyzes the files in the venv that isn't currently selected as if they were user files. I end up with a situation like so:

Exclude paths don't seem to fix the issue either. I tried this:

"python.analysis.exclude": ["venv1", "venv2"]

Additionally our help says all virtual environments are excluded automatically:

[rchiodo]

Turns out I had a workspace settings.json that listed just this:

"python.analysis.exclude": ["test_packages"]

This eliminated the defaults that skip virtual environments. If I remove that exclusion, then the virtual environments are excluded.

[rchiodo]

Perhaps the virtual environments could somehow be a separate setting? Not sure if this really matters anymore.

[rchiodo]

If the default listed out the default options, then this likely wouldn't have been an issue. Something like how the excludes for files does in VS code when you edit it:

    "files.exclude": {
        "**/.git": true,
        "**/.svn": true,
        "**/.hg": true,
        "**/CVS": true,
        "**/.DS_Store": true,
        "**/Thumbs.db": true
    }

[cwebster-99]

Rich Chiodo (@rchiodo) I thought this might have been resolved, does this problem still exist?

[rchiodo]

No this still reproduces. It's kind of a problem. I think we should change it to always exclude venv enviroments.

[goodspark]

Coming from the linked issue #7171. Another perspective here is - it's somewhat surprising that configuring excluded directories for pyright in my pyproject.toml file caused Pylance to run slowly bc it was no longer automatically detecting and skipping venvs during indexing. It makes sense if you're aware of the internals of Pylance (ie. it uses Pyright for diagnostics/analysis), but I feel like to outside users, pyright is a distinct tool (static type checker) separate from Pylance (a VSCode Python language server).

Before encountering this, I mentally modeled pyright as a mypy replacement and just that - I never considered how it will impact the VSCode Python extension's performance, much like how I don't consider configuring mypy will change how the Python extension behaves.

[rchiodo]

The comment here #7236 (reply in thread), seems to make sense too. We should exclude stuff in the .gitignore as well.