Setting strict mode and error action preference to stop on remaining PS scripts (#5950)

* Setting strict mode and error action preference to stop on remaining powershell scripts

* Fixing install VCLibs script

Author: guimafelipe

build/InstallVCLibs.ps1

@@ -2,12 +2,13 @@ param(
     [Parameter(Mandatory = $true)]
     [ValidateSet("x86", "x64", "arm64")]
     [string]$Platform,
-    
+
     # Expecting BuildOutput\Release
     [Parameter(Mandatory = $true)]
     [string]$SourceDirectory
 )
 
+Set-StrictMode -Version 3.0
 $ErrorActionPreference = "Stop"
 
 Write-Host "Installing VCLibs packages for platform: $Platform" -ForegroundColor Green
@@ -34,22 +35,21 @@ $InstalledPackages = @{}
 
 foreach ($Package in $VCLibsPackages) {
     $PackageName = $Package.Name
-    
+
     if ($InstalledPackages.ContainsKey($PackageName)) {
         continue
     }
-    
+
     try {
         Write-Host "Installing: $PackageName" -ForegroundColor White
         Add-AppxPackage -Path $Package.FullName -ForceApplicationShutdown
-        
+
         $InstalledPackages[$PackageName] = $Package.FullName
-        $TotalInstalled++
         Write-Host "  -> Success" -ForegroundColor Green
     }
     catch {
         Write-Error "Failed to install $PackageName`: $($_.Exception.Message)"
     }
 }
 
-Write-Host "Completed successfully!" -ForegroundColor Green
+Write-Host "Completed successfully!" -ForegroundColor Green

build/scripts/CopyContents.ps1

@@ -6,6 +6,9 @@ param (
   [string]$TargetDir = ''
 )
 
+Set-StrictMode -Version 3.0
+$ErrorActionPreference = 'Stop'
+
 foreach ($Contents in $ContentsList)
 {
     $ContentsPath = (Join-Path $SourceDir $Contents)

build/scripts/RobocopyWrapper.ps1

@@ -3,6 +3,10 @@ param (
     [string]$dest = "",
     [string]$options = "/E /XC /XN /XO /NJH /NJS /NDL /NP /NFL"
 )
+
+Set-StrictMode -Version 3.0
+$ErrorActionPreference = 'Stop'
+
 $robocopyCmd = "robocopy $source $dest $options"
 
 Invoke-Expression $robocopyCmd

tools/TerminalVelocity/Generate-TerminalVelocityFeatures.ps1

@@ -47,6 +47,7 @@ Param(
 )
 
 Set-StrictMode -Version 3.0
+$ErrorActionPreference = 'Stop'
 
 # Make sure Channel has the exact spelling even if the parameter had different case
 foreach ($c in "Experimental", "Preview", "Stable", "WindowsInbox")