Skip to content

Commit b90ccdf

Browse files
authored
Fix Installer singleton support. Don't try to copy obsolete .pri files to the TRansport package (#1344)
* Fixed copy/paste error for singleton * Remove obsolete Microsoft.WindowsAppSDK.pri
1 parent ff18e63 commit b90ccdf

2 files changed

Lines changed: 18 additions & 9 deletions

File tree

build/NuSpecs/build-nupkg.ps1

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,11 +109,8 @@ function ConfigureNugetCommandLine {
109109
ConfigureNugetCommandLine("Microsoft.WindowsAppSDK")
110110

111111
Copy-IntoNewDirectory -IfExists $BuildOutput\$BuildFlavor\x86\Microsoft.WindowsAppRuntime\Microsoft.WindowsAppRuntime.dll "$runtimesDir\win10-x86\native"
112-
Copy-IntoNewDirectory -IfExists $BuildOutput\$BuildFlavor\x86\Microsoft.WindowsAppRuntime\Microsoft.WindowsAppSDK.pri "$runtimesDir\win10-x86\native"
113112
Copy-IntoNewDirectory -IfExists $BuildOutput\$BuildFlavor\x64\Microsoft.WindowsAppRuntime\Microsoft.WindowsAppRuntime.dll "$runtimesDir\win10-x64\native"
114-
Copy-IntoNewDirectory -IfExists $BuildOutput\$BuildFlavor\x64\Microsoft.WindowsAppRuntime\Microsoft.WindowsAppSDK.pri "$runtimesDir\win10-x64\native"
115113
Copy-IntoNewDirectory -IfExists $BuildOutput\$BuildFlavor\arm64\Microsoft.WindowsAppRuntime\Microsoft.WindowsAppRuntime.dll "$runtimesDir\win10-arm64\native"
116-
Copy-IntoNewDirectory -IfExists $BuildOutput\$BuildFlavor\arm64\Microsoft.WindowsAppRuntime\Microsoft.WindowsAppSDK.pri "$runtimesDir\win10-arm64\native"
117114

118115
#
119116
# Build Windows App SDK package (with actual contents, i.e. not metapackage)

installer/dev/windowsappruntime_definitions.h

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -78,34 +78,34 @@
7878
#define WAR_MAIN_ARM64_PATH "..\\test\\testpackages\\main_arm64.msix"
7979
#endif
8080

81-
// x86 Main
81+
// x86 Singleton
8282
#define WAR_SINGLETON_X86_ID L"WAR_SINGLETONPACKAGE_X86"
8383
#define WAR_SINGLETON_X86_RCID WAR_SINGLETONPACKAGE_X86
8484
#define WAR_SINGLETON_X86_TYPE L"PACKAGE"
8585
#define WAR_SINGLETON_X86_RCTYPE PACKAGE
8686
#define WAR_SINGLETON_X86_BEHAVIOR DeploymentBehavior::Default
8787
#ifndef WAR_SINGLETON_X86_PATH
88-
#define WAR_SINGLETON_X86_PATH "..\\test\\testpackages\\main_x86.msix"
88+
#define WAR_SINGLETON_X86_PATH "..\\test\\testpackages\\singleton_x86.msix"
8989
#endif
9090

91-
// x64 Main
91+
// x64 Singleton
9292
#define WAR_SINGLETON_X64_ID L"WAR_SINGLETONPACKAGE_X64"
9393
#define WAR_SINGLETON_X64_RCID WAR_SINGLETONPACKAGE_X64
9494
#define WAR_SINGLETON_X64_TYPE L"PACKAGE"
9595
#define WAR_SINGLETON_X64_RCTYPE PACKAGE
9696
#define WAR_SINGLETON_X64_BEHAVIOR DeploymentBehavior::Default
9797
#ifndef WAR_SINGLETON_X64_PATH
98-
#define WAR_SINGLETON_X64_PATH "..\\test\\testpackages\\main_x64.msix"
98+
#define WAR_SINGLETON_X64_PATH "..\\test\\testpackages\\singleton_x64.msix"
9999
#endif
100100

101-
// arm64 Main
101+
// arm64 Singleton
102102
#define WAR_SINGLETON_ARM64_ID L"WAR_SINGLETONPACKAGE_ARM64"
103103
#define WAR_SINGLETON_ARM64_RCID WAR_SINGLETONPACKAGE_ARM64
104104
#define WAR_SINGLETON_ARM64_TYPE L"PACKAGE"
105105
#define WAR_SINGLETON_ARM64_RCTYPE PACKAGE
106106
#define WAR_SINGLETON_ARM64_BEHAVIOR DeploymentBehavior::Default
107107
#ifndef WAR_SINGLETON_ARM64_PATH
108-
#define WAR_SINGLETON_ARM64_PATH "..\\test\\testpackages\\main_arm64.msix"
108+
#define WAR_SINGLETON_ARM64_PATH "..\\test\\testpackages\\singleton_arm64.msix"
109109
#endif
110110

111111
// x86 DDLM
@@ -167,6 +167,18 @@
167167
#define WAR_MAIN_ARM64_RCENTRY WAR_MAIN_ARM64_RC WAR_MAIN_ARM64_RCTYPE WAR_MAIN_ARM64_PATH
168168
#endif
169169

170+
#define WAR_SINGLETON_X86_LISTENTRY { WAR_SINGLETON_X86_ID, WAR_SINGLETON_X86_TYPE, WAR_SINGLETON_X86_BEHAVIOR },
171+
#define WAR_SINGLETON_X86_RCENTRY WAR_SINGLETON_X86_RCID WAR_SINGLETON_X86_RCTYPE WAR_SINGLETON_X86_PATH
172+
173+
#define WAR_SINGLETON_X64_LISTENTRY { WAR_SINGLETON_X64_ID, WAR_SINGLETON_X64_TYPE, WAR_SINGLETON_X64_BEHAVIOR },
174+
#define WAR_SINGLETON_X64_RCENTRY WAR_SINGLETON_X64_RCID WAR_SINGLETON_X64_RCTYPE WAR_SINGLETON_X64_PATH
175+
176+
// arm64 is included only on arm64 builds
177+
#if defined(_M_ARM64)
178+
#define WAR_SINGLETON_ARM64_LISTENTRY { WAR_SINGLETON_ARM64_ID, WAR_SINGLETON_ARM64_TYPE, WAR_SINGLETON_ARM64_BEHAVIOR },
179+
#define WAR_SINGLETON_ARM64_RCENTRY WAR_SINGLETON_ARM64_RC WAR_SINGLETON_ARM64_RCTYPE WAR_SINGLETON_ARM64_PATH
180+
#endif
181+
170182
#define WAR_DDLM_X86_LISTENTRY { WAR_DDLM_X86_ID, WAR_DDLM_X86_TYPE, WAR_DDLM_X86_BEHAVIOR },
171183
#define WAR_DDLM_X86_RCENTRY WAR_DDLM_X86_RCID WAR_DDLM_X86_RCTYPE WAR_DDLM_X86_PATH
172184

0 commit comments

Comments
 (0)