Fixing and enabling AppLifecycle tests (#5719)

* Changing names to prefixes

* Enabling test

* Adding script to add missing dependency

* Revert "Adding script to add missing dependency"

This reverts commit f396678.

* Reapply "Adding script to add missing dependency"

This reverts commit d1d4e86.

* Adding new script to download UWP version of VCLibs

* Adding the ps1 script I forgot

* Trying copying from VS

* Removing installation of unexisting UWP packages

* Using package manifest for vclibs

* Fixing version

* Removing install of VClibs in yml file

* Putting version to 0

* Implementing TODO

* Adding entry to bypass tests

* Bypassing every individual test

Author: guimafelipe

build/AzurePipelinesTemplates/WindowsAppSDK-RunTests-Steps.yml

@@ -76,14 +76,6 @@ steps:
       script: |
             $(Build.SourcesDirectory)\redist\dotnet-windowsdesktop-runtime-installer.exe /quiet /install /norestart
 
-  - task: powerShell@2
-    displayName: 'Install VCLibs.Desktop'
-    inputs:
-      targetType: 'inline'
-      script: |
-            $package = "$(Build.SourcesDirectory)\redist\Microsoft.VCLibs.${{ parameters.buildPlatform }}.14.00.Desktop.appx"
-            Add-AppxPackage $package -ErrorAction SilentlyContinue
-
   - task: powerShell@2
     displayName: 'Install vc_redist'
     inputs:

test/AppLifecycle/AppLifecycle.testdef

@@ -5,7 +5,7 @@
             "Filename": "AppLifecycleTests.dll",
             "Parameters": "",
             "Architectures": ["x64", "arm64"],
-            "Status": "Disabled"
+            "Status": "Enabled"
         }
     ]
 }

test/BypassTests.json

@@ -1525,5 +1525,18 @@
   "release_x86_Windows.Server.2019.DataCenter.zh-CN.Test::Decimal::Tests::DecimalTests::from_zstring_view_localename_system",
   "release_x86_Windows.Server.2019.DataCenter.zh-CN.Test::Decimal::Tests::DecimalTests::from_zwstring_view",
   "release_x86_Windows.Server.2019.DataCenter.zh-CN.Test::Decimal::Tests::DecimalTests::from_zwstring_view_invariant",
-  "release_x86_Windows.Server.2019.DataCenter.zh-CN.Test::Decimal::Tests::DecimalTests::from_zwstring_view_localename_system"
+  "release_x86_Windows.Server.2019.DataCenter.zh-CN.Test::Decimal::Tests::DecimalTests::from_zwstring_view_localename_system",
+  "release_x64_Win10_rs5_DC.Test::AppLifecycle::FunctionalTests::GetActivatedEventArgsIsNotNull",
+  "release_x64_Win10_rs5_DC.Test::AppLifecycle::FunctionalTests::GetActivatedEventArgsForLaunch",
+  "release_x64_Win10_rs5_DC.Test::AppLifecycle::FunctionalTests::GetActivatedEventArgsForFile_Win32",
+  "release_x64_Win10_rs5_DC.Test::AppLifecycle::FunctionalTests::GetActivatedEventArgsForUnicodeNamedFile_Win32",
+  "release_x64_Win10_rs5_DC.Test::AppLifecycle::FunctionalTests::GetActivatedEventArgsForFile_PackagedWin32",
+  "release_x64_Win10_rs5_DC.Test::AppLifecycle::FunctionalTests::GetActivatedEventArgsForProtocol_Win32",
+  "release_x64_Win10_rs5_DC.Test::AppLifecycle::FunctionalTests::GetActivatedEventArgsForProtocol_PackagedWin32",
+  "release_x64_Win10_rs5_DC.Test::AppLifecycle::FunctionalTests::GetActivatedEventArgsForPush_Win32",
+  "release_x64_Win10_rs5_DC.Test::AppLifecycle::FunctionalTests::GetActivatedEventArgsForStartup_Win32",
+  "release_x64_Win10_rs5_DC.Test::AppLifecycle::FunctionalTests::SingleInstanceTest_Win32",
+  "release_x64_Win10_rs5_DC.Test::AppLifecycle::FunctionalTests::SingleInstanceTest_PackagedWin32",
+  "release_x64_Win10_rs5_DC.Test::AppLifecycle::FunctionalTests::RequestRestart_Win32",
+  "release_x64_Win10_rs5_DC.Test::AppLifecycle::FunctionalTests::RequestRestart_PackagedWin32"
 ]

test/TestApps/AppLifecycleTestApp/Helpers.cpp

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation and Contributors. All rights reserved.
+// Copyright (c) Microsoft Corporation and Contributors. All rights reserved.
 // Licensed under the MIT License. See LICENSE in the project root for license information.
 #include "pch.h"
 #include "Helpers.h"
@@ -42,9 +42,9 @@ HRESULT BootstrapInitialize()
 
     constexpr PCWSTR c_PackageNamePrefix{ L"WindowsAppRuntime.Test.DDLM" };
     constexpr PCWSTR c_PackagePublisherId{ L"8wekyb3d8bbwe" };
-    constexpr PCWSTR c_FrameworkPackageFamilyName = L"Microsoft.WindowsAppRuntime.Framework.4.1_8wekyb3d8bbwe";
-    constexpr PCWSTR c_MainPackageFamilyName = L"WindowsAppRuntime.Test.DynDep.DataStore.4.1_8wekyb3d8bbwe";
-    RETURN_IF_FAILED(mddTestInitialize(c_PackageNamePrefix, c_PackagePublisherId, c_FrameworkPackageFamilyName, c_MainPackageFamilyName));
+    constexpr PCWSTR c_FrameworkPackageNamePrefix = L"Microsoft.WindowsAppRuntime.Framework";
+    constexpr PCWSTR c_MainPackageNamePrefix = L"WindowsAppRuntime.Test.DynDep.DataStore";
+    RETURN_IF_FAILED(mddTestInitialize(c_PackageNamePrefix, c_PackagePublisherId, c_FrameworkPackageNamePrefix, c_MainPackageNamePrefix));
 
     // Major.Minor version, MinVersion=0 to find any framework package for this major.minor version
     const UINT32 c_Version_MajorMinor{ 0x00040001 };

test/TestApps/AppLifecycleTestApp/main.cpp

@@ -91,7 +91,15 @@ int main()
                 }
                 catch (...)
                 {
-                    //TODO:Unregister should not fail if ERROR_FILE_NOT_FOUND | ERROR_PATH_NOT_FOUND
+                    // Unregister should not fail if ERROR_FILE_NOT_FOUND | ERROR_PATH_NOT_FOUND
+                    // These errors indicate the registration doesn't exist, which is the desired state
+                    auto hr = winrt::to_hresult();
+                    if (hr == HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND) || hr == HRESULT_FROM_WIN32(ERROR_PATH_NOT_FOUND))
+                    {
+                        // Signal event that protocol was unregistered (or already didn't exist).
+                        SignalPhase(c_testProtocolPhaseEventName);
+                        succeeded = true;
+                    }
                 }
             }
             else if (argument.compare(L"RegisterFile") == 0)
@@ -116,7 +124,15 @@ int main()
                 }
                 catch (...)
                 {
-                    //TODO:Unregister should not fail if ERROR_FILE_NOT_FOUND | ERROR_PATH_NOT_FOUND
+                    // Unregister should not fail if ERROR_FILE_NOT_FOUND | ERROR_PATH_NOT_FOUND
+                    // These errors indicate the registration doesn't exist, which is the desired state
+                    auto hr = winrt::to_hresult();
+                    if (hr == HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND) || hr == HRESULT_FROM_WIN32(ERROR_PATH_NOT_FOUND))
+                    {
+                        // Signal event that file was unregistered (or already didn't exist).
+                        SignalPhase(c_testFilePhaseEventName);
+                        succeeded = true;
+                    }
                 }
             }
             else if (argument.compare(L"RegisterStartup") == 0)

test/TestApps/AppLifecycleTestPackage/Package.appxmanifest

@@ -21,6 +21,7 @@
     <TargetDeviceFamily Name="Windows.Universal" MinVersion="10.0.0.0" MaxVersionTested="10.0.0.0" />
     <TargetDeviceFamily Name="Windows.Desktop" MinVersion="10.0.17763.0" MaxVersionTested="10.0.18362.0" />
     <PackageDependency Name="Microsoft.WindowsAppRuntime.Framework.4.1" Publisher="CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US" MinVersion="0.0.0.0"/>
+    <PackageDependency Name="Microsoft.VCLibs.140.00.UWPDesktop" MinVersion="0.0.0.0" Publisher="CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US" />
   </Dependencies>
 
   <Resources>