Skip to content

Commit 8c6bc94

Browse files
jonwisjonwis
authored
Reduce overbuilding for WASDK devs and end customers (#5595)
* Skip unchanged files in nuspecs Seeing some potential "overbuilding" (or at least noise in my diagnostics) about this file being copied repeatedly. MSBuild's <Copy/> task always copies, unless https://learn.microsoft.com/en-us/dotnet/api/microsoft.build.tasks.copy.skipunchangedfiles?view=msbuild-17-netcore is set. * More skip-unchanged-files
1 parent ed9ed90 commit 8c6bc94

43 files changed

Lines changed: 62 additions & 61 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎build/NuSpecs/WindowsAppSDK-Nuget-Native.C.props‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
<Target Name="CopyMicrosoftWindowsAppRuntimeBootstrapdllToOutDir" Condition="'$(AppxPackage)' != 'true'" AfterTargets="Build" BeforeTargets="Binplace">
3636
<Copy
3737
SourceFiles="$(MSBuildThisFileDirectory)..\..\runtimes\win-$(_WindowsAppSDKFoundationPlatform)\native\Microsoft.WindowsAppRuntime.Bootstrap.dll"
38+
SkipUnchangedFiles="true"
3839
DestinationFolder="$(OutDir)"/>
3940
</Target>
4041

‎dev/DynamicDependencyDataStore/DynamicDependency.DataStore.ProxyStub/DynamicDependency.DataStore.ProxyStub.vcxproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@
290290
</ItemGroup>
291291
<!-- Include header files from the dev chunks -->
292292
<Target Name="CopyFiles" AfterTargets="AfterBuild">
293-
<Copy SourceFiles="@(PublicHeaders)" DestinationFolder="$(OutDir)" />
293+
<Copy SkipUnchangedFiles="true" SourceFiles="@(PublicHeaders)" DestinationFolder="$(OutDir)" />
294294
</Target>
295295
<Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
296296
<PropertyGroup>

‎dev/DynamicDependencyLifetimeManager/DynamicDependencyLifetimeManager.ProxyStub/DynamicDependencyLifetimeManager.ProxyStub.vcxproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@
299299
</ItemGroup>
300300
<!-- Include header files from the dev chunks -->
301301
<Target Name="CopyFiles" AfterTargets="AfterBuild">
302-
<Copy SourceFiles="@(PublicHeaders)" DestinationFolder="$(OutDir)" />
302+
<Copy SkipUnchangedFiles="true" SourceFiles="@(PublicHeaders)" DestinationFolder="$(OutDir)" />
303303
</Target>
304304
<Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
305305
<PropertyGroup>

‎dev/MRTCore/mrt/Core/unittests/MrmUnitTest.vcxproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,6 @@
213213
<Error Condition="!Exists('$(NugetPackageDirectory)\Microsoft.Taef.$(MicrosoftTaefVersion)\build\Microsoft.Taef.targets')" Text="$([System.String]::Format('$(ErrorText)', '$(NugetPackageDirectory)\Microsoft.Taef.$(MicrosoftTaefVersion)\build\Microsoft.Taef.targets'))" />
214214
</Target>
215215
<Target Name="CopyFiles" AfterTargets="AfterBuild">
216-
<Copy SourceFiles="MrmUnitTest.testdef" DestinationFolder="$(OutDir)" />
216+
<Copy SkipUnchangedFiles="true" SourceFiles="MrmUnitTest.testdef" DestinationFolder="$(OutDir)" />
217217
</Target>
218218
</Project>

‎dev/MRTCore/mrt/Microsoft.Windows.ApplicationModel.Resources/UnpackagedTests/MrtCoreUnpackagedTests.csproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,6 @@
105105
</Target>
106106
-->
107107
<Target Name="CopyFiles" AfterTargets="AfterBuild">
108-
<Copy SourceFiles="MrtCoreUnpackagedTests.testdef" DestinationFolder="$(OutDir)" />
108+
<Copy SkipUnchangedFiles="true" SourceFiles="MrtCoreUnpackagedTests.testdef" DestinationFolder="$(OutDir)" />
109109
</Target>
110110
</Project>

‎dev/MRTCore/mrt/Microsoft.Windows.ApplicationModel.Resources/unittests/MrtCoreManagedTest.csproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,6 @@
230230
</Target>
231231
-->
232232
<Target Name="CopyFiles" AfterTargets="AfterBuild">
233-
<Copy SourceFiles="MrtCoreManagedTest.testdef" DestinationFolder="$(OutDir)" />
233+
<Copy SkipUnchangedFiles="true" SourceFiles="MrtCoreManagedTest.testdef" DestinationFolder="$(OutDir)" />
234234
</Target>
235235
</Project>

‎dev/MRTCore/mrt/mrm/UnitTests/MrmBaseUnitTests.vcxproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,6 @@
243243
<Error Condition="!Exists('$(NugetPackageDirectory)\Microsoft.Taef.$(MicrosoftTaefVersion)\build\Microsoft.Taef.targets')" Text="$([System.String]::Format('$(ErrorText)', '$(NugetPackageDirectory)\Microsoft.Taef.$(MicrosoftTaefVersion)\build\Microsoft.Taef.targets'))" />
244244
</Target>
245245
<Target Name="CopyFiles" AfterTargets="AfterBuild">
246-
<Copy SourceFiles="MrmBaseUnitTests.testdef" DestinationFolder="$(OutDir)" />
246+
<Copy SkipUnchangedFiles="true" SourceFiles="MrmBaseUnitTests.testdef" DestinationFolder="$(OutDir)" />
247247
</Target>
248248
</Project>

‎dev/PushNotifications/PushNotificationsLongRunningTask.ProxyStub/PushNotificationsLongRunningTask.ProxyStub.vcxproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,7 @@
463463
</ItemGroup>
464464
<!-- Include header files from the dev chunks -->
465465
<Target Name="CopyFiles" AfterTargets="AfterBuild">
466-
<Copy SourceFiles="@(PublicHeaders)" DestinationFolder="$(OutDir)" />
466+
<Copy SkipUnchangedFiles="true" SourceFiles="@(PublicHeaders)" DestinationFolder="$(OutDir)" />
467467
</Target>
468468
<Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
469469
<PropertyGroup>

‎dev/VSIX/Extension/Directory.Build.targets‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
<BinRoot Condition="$(BinRoot) == ''">$(OutputPath)</BinRoot>
3939
</PropertyGroup>
4040
<Message Importance="high" Text="Binplacing to: $(BinRoot)" />
41-
<Copy SourceFiles="$(TargetVsixContainer)" DestinationFolder="$(BinRoot)"/>
41+
<Copy SkipUnchangedFiles="true" SourceFiles="$(TargetVsixContainer)" DestinationFolder="$(BinRoot)"/>
4242
<Move Condition="'$(JsonName)' != '' AND Exists('$(BaseIntermediateOutputPath)\$(JsonName)')" SourceFiles="$(BaseIntermediateOutputPath)\$(JsonName)" DestinationFiles="$(BaseIntermediateOutputPath)\$(AssemblyName).$(Deployment).json"/>
4343
</Target>
4444

‎dev/WindowsAppRuntime_BootstrapDLL/WindowsAppRuntime_BootstrapDLL.vcxproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@
315315
</Target>
316316
<!-- Include header files from the dev chunks -->
317317
<Target Name="CopyFiles" AfterTargets="AfterBuild">
318-
<Copy SourceFiles="@(PublicHeaders)" DestinationFolder="$(OutDir)" />
318+
<Copy SkipUnchangedFiles="true" SourceFiles="@(PublicHeaders)" DestinationFolder="$(OutDir)" />
319319
</Target>
320320
<ItemGroup>
321321
<PublicHeaders Include="$(MSBuildThisFileDirectory)MddBootstrap.h" />

0 commit comments

Comments
 (0)