Skip to content

Commit 6fac824

Browse files
committed
Update VSIX to work with Dev17 (#936)
This change updates the VSIX to target the next version of VS. Fortunately, this VSIX contains only templates and no code, so it can target both Dev16 and Dev17 fairly easily.
1 parent 0be5366 commit 6fac824

3 files changed

Lines changed: 25 additions & 10 deletions

File tree

dev/VSIX/Directory.Build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
https://pkgs.dev.azure.com/microsoft/ProjectReunion/_packaging/Project.Reunion.nuget.internal/nuget/v3/index.json
88
</RestoreSources>
99
<CppWinRTVersion Condition="'$(CppWinRTVersion)' == ''">2.0.210211.2</CppWinRTVersion>
10-
<ReunionVersion Condition="'$(ReunionVersion)' == ''">0.5.0-prerelease.20210304.5.ci</ReunionVersion>
10+
<ReunionVersion Condition="'$(ReunionVersion)' == ''">0.5.7</ReunionVersion>
1111
</PropertyGroup>
1212

1313
<PropertyGroup>

dev/VSIX/Extension/ProjectReunion.Extension.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,11 @@
5353
<Reference Include="System" />
5454
</ItemGroup>
5555
<ItemGroup>
56-
<PackageReference Include="Microsoft.VisualStudio.SDK" Version="16.0.206" ExcludeAssets="runtime">
56+
<PackageReference Include="Microsoft.VisualStudio.SDK" Version="17.0.0-previews-1-31325-273" ExcludeAssets="runtime">
5757
<IncludeAssets>compile; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
5858
</PackageReference>
5959
<PackageReference Include="System.Net.Http" Version="4.3.4" />
60-
<PackageReference Include="Microsoft.VSSDK.BuildTools" Version="16.8.1017">
60+
<PackageReference Include="Microsoft.VSSDK.BuildTools" Version="17.0.1600">
6161
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
6262
<PrivateAssets>all</PrivateAssets>
6363
</PackageReference>
@@ -284,7 +284,7 @@
284284
Condition="'$(EnableExperimentalVSIXFeatures)'=='true'"
285285
XmlInputPath="$(VsixManifestSource)"
286286
Query="/ns:PackageManifest/ns:Metadata/ns:Identity/@Id"
287-
Value="$(_OriginalVsixId).Preview"
287+
Value="$(_OriginalVsixId).Preview"
288288
Namespaces="&lt;Namespace Prefix='ns' Uri='http://schemas.microsoft.com/developer/vsx-schema/2011' /&gt;" />
289289
<XmlPoke
290290
Condition="'$(EnableExperimentalVSIXFeatures)'=='true'"

dev/VSIX/Extension/source.extension.vsixmanifest

Lines changed: 21 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,17 +14,32 @@
1414
<Preview>false</Preview>
1515
</Metadata>
1616
<Installation AllUsers="true">
17-
<InstallationTarget Id="Microsoft.VisualStudio.Community" Version="[16.9, 17.0)" />
18-
<InstallationTarget Id="Microsoft.VisualStudio.Pro" Version="[16.9, 17.0)" />
19-
<InstallationTarget Id="Microsoft.VisualStudio.Enterprise" Version="[16.9, 17.0)" />
17+
<InstallationTarget Id="Microsoft.VisualStudio.Community" Version="[16.9, 17.0)">
18+
<ProductArchitecture>x86</ProductArchitecture>
19+
</InstallationTarget>
20+
<InstallationTarget Id="Microsoft.VisualStudio.Community" Version="[17.0, 18.0)">
21+
<ProductArchitecture>amd64</ProductArchitecture>
22+
</InstallationTarget>
23+
<InstallationTarget Id="Microsoft.VisualStudio.Pro" Version="[16.9, 17.0)">
24+
<ProductArchitecture>x86</ProductArchitecture>
25+
</InstallationTarget>
26+
<InstallationTarget Id="Microsoft.VisualStudio.Pro" Version="[17.0, 18.0)">
27+
<ProductArchitecture>amd64</ProductArchitecture>
28+
</InstallationTarget>
29+
<InstallationTarget Id="Microsoft.VisualStudio.Enterprise" Version="[16.9, 17.0)">
30+
<ProductArchitecture>x86</ProductArchitecture>
31+
</InstallationTarget>
32+
<InstallationTarget Id="Microsoft.VisualStudio.Enterprise" Version="[17.0, 18.0)">
33+
<ProductArchitecture>amd64</ProductArchitecture>
34+
</InstallationTarget>
2035
</Installation>
2136
<Dependencies>
2237
<Dependency Id="Microsoft.Framework.NDP" DisplayName="Microsoft .NET Framework" d:Source="Manual" Version="[4.5,)" />
2338
</Dependencies>
2439
<Prerequisites>
25-
<Prerequisite Id="Microsoft.VisualStudio.Component.CoreEditor" Version="[16.0,17.0)" DisplayName="Visual Studio core editor" />
26-
<Prerequisite Id="Microsoft.VisualStudio.ComponentGroup.UWP.Support" Version="[16.2.29003.222,17.0)" DisplayName="Universal Windows Platform tools" />
27-
<Prerequisite Id="Microsoft.VisualStudio.ComponentGroup.UWP.VC" Version="[16.0,17.0)" DisplayName="C++ (v142) Universal Windows Platform tools" />
40+
<Prerequisite Id="Microsoft.VisualStudio.Component.CoreEditor" Version="[16.0,18.0)" DisplayName="Visual Studio core editor" />
41+
<Prerequisite Id="Microsoft.VisualStudio.ComponentGroup.UWP.Support" Version="[16.2.29003.222,18.0)" DisplayName="Universal Windows Platform tools" />
42+
<Prerequisite Id="Microsoft.VisualStudio.ComponentGroup.UWP.VC" Version="[16.0,18.0)" DisplayName="C++ (v142) Universal Windows Platform tools" />
2843
</Prerequisites>
2944
<Reference Id="NuPackToolsVsix.Microsoft.67e54e40-0ae3-42c5-a949-fddf5739e7a5" MinVersion="1.7.30402.9028">
3045
<Name>NuGet Package Manager</Name>

0 commit comments

Comments
 (0)