Fix the versioning on Foundation nuspec (#800)

Author: kythant

build/AzurePipelinesTemplates/ProjectReunion-CreateNugetPackage-Job.yml

@@ -7,12 +7,8 @@ parameters:
 # The "primary" build arch is the one that the nuspec gets its winmd, pri, and other neutral files from
   primaryBuildArch: x86
   buildFlavor: Release
-  useReleaseTag: 'false'
   prereleaseVersionTag: 'prerelease'
   condition: ''
-  major: '0'
-  minor: '5'
-  patch: '0'
 
 jobs:
 - job: ${{ parameters.jobName }}
@@ -31,7 +27,6 @@ jobs:
       echo parameters.publishPath '${{ parameters.publishPath }}'
       echo buildrevision=$(buildrevision)
       echo builddate=$(builddate)
-      echo useReleaseTag=${{ parameters.useReleaseTag }}
     displayName: 'CreateNugetPackage: Display parameters'
 
   - task: DownloadBuildArtifacts@0
@@ -87,15 +82,23 @@ jobs:
 
   #   displayName: 'build-nupkg.ps1'
 
+  - task: PowerShell@2
+    displayName: Update metapackage version
+    inputs:
+      targetType: 'inline'
+      script: |
+        $packageVersion = '$(version).${{ parameters.prereleaseVersionTag }}'
+        Write-Host version: $packageVersion
+        [xml]$publicNuspec = Get-Content -Path $(Build.SourcesDirectory)\build\NuSpecs\Microsoft.ProjectReunion.Foundation.nuspec
+        $publicNuspec.package.metadata.version = $packageVersion
+        Set-Content -Value $publicNuspec.OuterXml $(Build.SourcesDirectory)\build\NuSpecs\Microsoft.ProjectReunion.Foundation.nuspec
+
   - task: 333b11bd-d341-40d9-afcf-b32d5ce6f23b@2
     displayName: 'Pack Full Nuget Package'
     inputs:
       command: 'pack'
       packagesToPack: '$(Build.SourcesDirectory)\build\NuSpecs\Microsoft.ProjectReunion.Foundation.nuspec'
-      versioningScheme: 'byPrereleaseNumber'
-      majorVersion: ${{ parameters.major }}
-      minorVersion: ${{ parameters.minor }}
-      patchVersion: ${{ parameters.patch }}
+      versioningScheme: 'off'
       basePath: '${{ parameters.fullnupkgdir }}'
       packDestination: ${{ parameters.fullnupkgdir }}
 

build/ProjectReunion-BuildFoundation.yml

@@ -1,6 +1,7 @@
 name: $(BuildDefinitionName)_$(date:yyMM).$(date:dd)$(rev:rrr)
 variables:
-  minimumExpectedTestsExecutedCount: 35  # Sanity check for minimum expected tests to be reported
+- template: ProjectReunion-Versions.yml
+- template: ProjectReunion-CommonVariables.yml
 
 parameters:
   - name: "ReleaseSigning"
@@ -361,7 +362,7 @@ jobs:
     dependsOn: SignBinariesAndPublishSymbols
     signConfigPattern: 'Microsoft.ProjectReunion*.nupkg'
     useReleaseTag: '$(ProjectReunionFinalRelease)'
-    prereleaseVersionTag: prerelease
+    prereleaseVersionTag: nightly
 
 # Build solution that depends on nuget package
 #- template: AzurePipelinesTemplates\ProjectReunion-NugetReleaseTest-Job.yml

build/ProjectReunion-CI.yml

@@ -1,8 +1,8 @@
 # see https://docs.microsoft.com/en-us/azure/devops/pipelines/process/phases for info on yaml ADO jobs
 name: $(BuildDefinitionName)_$(date:yyMM).$(date:dd)$(rev:rrr)
 variables:
-  minimumExpectedTestsExecutedCount: 500  # Sanity check for minimum expected tests to be reported
-  rerunPassesRequiredToAvoidFailure: 5
+- template: ProjectReunion-Versions.yml
+- template: ProjectReunion-CommonVariables.yml
 
 jobs:
 - job: CredScan

build/ProjectReunion-CommonVariables.yml

@@ -0,0 +1,8 @@
+variables:
+  rerunPassesRequiredToAvoidFailure: 5
+  versionDate: $[format('{0:yyyyMMdd}', pipeline.startTime)]
+  versionCounter: $[counter(variables['versionDate'], 0)]
+  version: >
+   $[format('{0}.{1}.{2}-{3}.{4}.{5}', 
+      variables['major'], variables['minor'], variables['patch'], variables['branch'],
+      variables['versionDate'], variables['versionCounter'])]

build/ProjectReunion-PR.yml

@@ -0,0 +1,6 @@
+variables:
+  # Version Control
+  major: "0"
+  minor: "8"
+  patch: "0"
+  branch: 'main'