salvage: ROS2 Humble build deps and tf2 headers (credit @quykova #5058)

Humble-friendly tf2_geometry_msgs.hpp includes, drop obsolete stdc++fs
linkage, gcc/clang 12 toolchains, and missing ROS2 package deps.
Based on @quykova #5058 with sequential find_package de-duped.

Signed-off-by: Bartok9 <[email protected]>

Author: Bartok9

Unity/build.sh

@@ -18,8 +18,8 @@ fi
 
 cd linux-build
 if [ "$(uname)" == "Darwin" ]; then
-    export CC=/usr/local/opt/llvm@8/bin/clang
-    export CXX=/usr/local/opt/llvm@8/bin/clang++
+    export CC=/usr/local/opt/llvm@12/bin/clang
+    export CXX=/usr/local/opt/llvm@12/bin/clang++
 else
     export CC="clang-8"
     export CXX="clang++-8"

build.sh

@@ -64,11 +64,11 @@ if [ "$(uname)" == "Darwin" ]; then
     export CXX="$(brew --prefix)/opt/llvm/bin/clang++"
 else
     if $gcc; then
-        export CC="gcc-8"
-        export CXX="g++-8"
+        export CC="gcc-12"
+        export CXX="g++-12"
     else
-        export CC="clang-8"
-        export CXX="clang++-8"
+        export CC="clang-12"
+        export CXX="clang++-12"
     fi
 fi
 

cmake/cmake-modules/CommonSetup.cmake

@@ -59,9 +59,9 @@ macro(CommonSetup)
             if (${CMAKE_CXX_COMPILER_ID} MATCHES "Clang")
                 set(CMAKE_CXX_FLAGS "-stdlib=libc++ -Wno-documentation -Wno-unknown-warning-option ${CMAKE_CXX_FLAGS}")
                 find_package(LLVM REQUIRED CONFIG)
-                set(CXX_EXP_LIB "-L${LLVM_LIBRARY_DIRS} -lc++fs -ferror-limit=10")
+                set(CXX_EXP_LIB "-L${LLVM_LIBRARY_DIRS} -ferror-limit=10")
             else()
-                set(CXX_EXP_LIB "-lstdc++fs -fmax-errors=10 -Wnoexcept -Wstrict-null-sentinel")
+                set(CXX_EXP_LIB "-fmax-errors=10 -Wnoexcept -Wstrict-null-sentinel")
             endif ()
         endif ()
 

ros2/src/airsim_ros_pkgs/CMakeLists.txt

@@ -30,11 +30,11 @@ add_subdirectory("${AIRSIM_ROOT}/cmake/AirLib" AirLib)
 add_subdirectory("${AIRSIM_ROOT}/cmake/MavLinkCom" MavLinkCom)
 
 set(CMAKE_CXX_STANDARD 14)
-set(CMAKE_CXX_FLAGS "-O3 -Wall -Wextra -Wnoexcept -Wstrict-null-sentinel")
+set(CMAKE_CXX_FLAGS "-O3 -Wall -Wextra -Wnoexcept -Wstrict-null-sentinel -Wno-deprecated-copy")
 set(CXX_EXP_LIB "-nostdinc++ -I/usr/include/c++/8 -I/usr/include/x86_64-linux-gnu/c++/8 -nodefaultlibs 
 -l/usr/lib/x86_64-linux-gnu/libc++.so -l/usr/lib/x86_64-linux-gnu/libc++abi.so
 -lm -lc -lgcc_s -lgcc
--lstdc++fs -fmax-errors=10")
+-fmax-errors=10")
 set(RPC_LIB_INCLUDES " ${AIRSIM_ROOT}/external/rpclib/rpclib-2.3.0/include")
 set(RPC_LIB rpc)
 message(STATUS "found RPC_LIB_INCLUDES=${RPC_LIB_INCLUDES}")
@@ -46,6 +46,8 @@ set(INCLUDE_DIRS include
   ${AIRSIM_ROOT}/MavLinkCom/include
   ${AIRSIM_ROOT}/MavLinkCom/common_utils
   ${OpenCV_INCLUDE_DIRS}
+  ${std_srvs_INCLUDE_DIRS}
+  ${mavros_msgs_INCLUDE_DIRS}
   )
 include_directories(${INCLUDE_DIRS})
 
@@ -59,6 +61,8 @@ ament_target_dependencies(pd_position_controller_simple
   nav_msgs
   geometry_msgs
   airsim_interfaces
+  tf2
+  tf2_geometry_msgs
 )
 
 add_library(airsim_ros src/airsim_ros_wrapper.cpp)
@@ -72,12 +76,17 @@ ament_target_dependencies(airsim_ros
   tf2_ros
   cv_bridge
   airsim_interfaces
+  tf2_geometry_msgs
+  mavros_msgs
+  std_srvs
 )
 
 add_executable(airsim_node src/airsim_node.cpp)
 target_link_libraries(airsim_node airsim_ros AirLib)
 ament_target_dependencies(airsim_node 
   rclcpp
+  tf2
+  tf2_geometry_msgs
 )
 
 add_executable(pd_position_controller_simple_node
@@ -86,6 +95,8 @@ target_link_libraries(pd_position_controller_simple_node
   pd_position_controller_simple airsim_ros AirLib)
 ament_target_dependencies(pd_position_controller_simple_node 
   rclcpp
+  tf2
+  tf2_geometry_msgs
 )
 
 # rosidl_target_interfaces(airsim_node

ros2/src/airsim_ros_pkgs/include/pd_position_controller_simple.h

@@ -15,7 +15,7 @@ STRICT_MODE_OFF //todo what does this do?
 #include <rclcpp/rclcpp.hpp>
 #include <tf2/LinearMath/Matrix3x3.h>
 #include <tf2/LinearMath/Quaternion.h>
-#include <tf2_geometry_msgs/tf2_geometry_msgs.h>
+#include <tf2_geometry_msgs/tf2_geometry_msgs.hpp>
 #include <nav_msgs/msg/odometry.hpp>
 #include <math.h>
 #include <airsim_interfaces/msg/vel_cmd.hpp>

ros2/src/airsim_ros_pkgs/include/utils.h

@@ -1,4 +1,4 @@
-#include <tf2_geometry_msgs/tf2_geometry_msgs.h>
+#include <tf2_geometry_msgs/tf2_geometry_msgs.hpp>
 namespace utils
 {
 inline double get_yaw_from_quat_msg(const geometry_msgs::msg::Quaternion& quat_msg)

ros2/src/airsim_ros_pkgs/package.xml

@@ -35,6 +35,8 @@
   <exec_depend>image_transport</exec_depend>
   <exec_depend>message_generation</exec_depend>
   <exec_depend>message_runtime</exec_depend>
+  <exec_depend>mavros_msgs</exec_depend>
+  <exec_depend>std_srvs</exec_depend>
   <exec_depend>nav_msgs</exec_depend>
   <exec_depend>rclcpp</exec_depend>
   <exec_depend>rclpy</exec_depend>