Skip to content

claims: add high-precision success phrases agents actually use #50

Description

@aadi-joshi

Summary

Claim extraction in cngx/verify/claims.py is intentionally precision-first. A few strong phrases that coding agents use a lot still miss, which weakens --require-claim workflows.

Why

False negatives on clear success claims mean --require-claim can block honest agents. We only want strong phrases, never vague ones.

Scope

Add only high-precision patterns such as (examples, adjust with tests):

  • CI is green / CI green
  • all checks passed
  • tests are green (with care)
  • suite is green

Document why each is safe in the PR. Do not match weak phrases like done, looks good, or should be fine.

Acceptance criteria

  • Positive tests in tests/unit/test_verify_claims.py for each new phrase
  • Negative tests confirming weak phrases still do not set claims_success
  • Short note in the claims section of CONTRIBUTING.md

Metadata

Metadata

Assignees

No one assigned

    Labels

    ELUSOCEligible for ELUSOC contributor program trackingNEWBIEELUSOC: beginner task (docs, small focused change)area: parsersTest-runner output parsing and claim extractionarea: verifyThe core verify command and verdict logicenhancementNew feature or requestgood first issueGood for newcomershelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions