Unable to sync third secondary pihole

[mike12806]

What happened?

I have 4 piholes, 1 primary and 3 secondary piholes. Whenever I had docker env variables for a 3rd secondary host, it's ignored by orbital sync and only the primary and first 2 secondary piholes are synced.

The issue occurs when adding the env variables:

SECONDARY_HOST_3_BASE_URL
SECONDARY_HOST_3_PASSWORD

Version

1.5.2

Log output

No response

[mike12806]

Hey @mattwebbio - any thoughts here?

[mattwebbio]

This smells like misconfiguration to me, but it's difficult to prove with the small amount of information you've provided. If you share more info (i.e. full configuration, verbose logs), I or someone in the community might be able to help - but there are tests in the code that test this configuration type and they all pass.

[mike12806]

Hey @mattwebbio - I need to add another pihole into my DNS cluster and was just poking at the code and I see an env variable mapped for....

SECONDARY_HOST_2

but nothing for....

SECONDARY_HOST_3

I see the test tests for 3 piholes (primary and 2 secondaries), but the example here implies I can sync up to 4.

Going to give it a shot later today - but are you open to me updating the test with a PR too?

[mattwebbio]

With Orbital Sync you can theoretically sync an unlimited number of piholes just by increasing the number in each env var. From the docs:

Replace (#) with a number, starting at 1, to add multiple. Each must be sequential, (i.e. SECONDARY_HOSTS_1_BASE_URL, SECONDARY_HOSTS_2_BASE_URL, SECONDARY_HOSTS_3_BASE_URL, and so on) and start at number 1. Any gaps (for example, 3 to 5 skipping 4) will result in configuration after the gap being skipped.

Source: https://orbitalsync.com/CONFIG.html#secondary-hosts

[mattwebbio]

I will happily accept a PR that adds a test with i.e. 9 or 20 Pi-holes if a stress test seems valuable 😄

[mike12806]

PR: #420 @mattwebbio - let me know if you have any feedback!

[mike12806]

Maybe I'm going crazy but doesn't seem to be working for me...although the tests do pass....

Env Variable Config:

env:

  | - name: PRIMARY_HOST_BASE_URL
  | value: 'http://192.168.9.3:1010'
  | - name: PRIMARY_HOST_PASSWORD
  | value: 'REDACTED'
  | - name: SECONDARY_HOST_1_BASE_URL
  | value: 'http://192.168.1.103:1010'
  | - name: SECONDARY_HOST_1_PASSWORD
  | value: 'REDACTED'
  | - name: SECONDARY_HOST_2_BASE_URL
  | value: 'http://192.168.1.86'
  | - name: SECONDARY_HOST_2_PASSWORD
  | value: 'REDACTED'
  | - name: SECONDARY_HOST_3_BASE_URL
  | value: 'http://192.168.1.53:90'
  | - name: SECONDARY_HOST_3_PASSWORD
  | value: 'REDACTED'
  | - name: INTERVAL_MINUTES
  | value: '15'
  | - name: NOTIFY_ON_FAILURE
  | value: 'true'
  | - name: NOTIFY_ON_SUCCESS
  | value: 'false'
  | - name: NOTIFY_SMTP_ENABLED
  | value: 'true'
  | - name: TZ
  | value: 'America/New_York'
  | - name: NOTIFY_SMTP_HOST
  | value: 'smtp.gmail.com'
  | - name: NOTIFY_SMTP_TLS
  | value: 'true'
  | - name: NOTIFY_SMTP_PORT
  | value: '465'
  | - name: NOTIFY_SMTP_USER
  | value: 'REDACTED'
  | - name: NOTIFY_SMTP_PASSWORD
  | value: 'REDACTED'
  | - name: NOTIFY_SMTP_FROM
  | value: 'REDACTED
  | - name: NOTIFY_SMTP_TO
  | value: 'REDACTED'

Logs:

9/5/2024, 8:52:49 PM: ➡️ Signing in to http://192.168.9.3:1010/admin...
2024-09-05T20:52:49.529687248-04:00 9/5/2024, 8:52:49 PM: ✔️ Successfully signed in to http://192.168.9.3:1010/admin!
2024-09-05T20:52:49.530028782-04:00 9/5/2024, 8:52:49 PM: ➡️ Downloading backup from http://192.168.9.3:1010/admin...
2024-09-05T20:52:49.589023778-04:00 9/5/2024, 8:52:49 PM: ✔️ Backup from http://192.168.9.3:1010/admin completed!
9/5/2024, 8:52:49 PM: ➡️ Signing in to http://192.168.1.103:1010/admin...
2024-09-05T20:52:49.590958653-04:00 9/5/2024, 8:52:49 PM: ➡️ Signing in to http://192.168.1.86/admin...
2024-09-05T20:52:49.630729791-04:00 9/5/2024, 8:52:49 PM: ✔️ Successfully signed in to http://192.168.1.86/admin!
2024-09-05T20:52:49.632198956-04:00 9/5/2024, 8:52:49 PM: ➡️ Uploading backup to http://192.168.1.86/admin...
2024-09-05T20:52:49.659642822-04:00 9/5/2024, 8:52:49 PM: ✔️ Successfully signed in to http://192.168.1.103:1010/admin!
2024-09-05T20:52:49.660832873-04:00 9/5/2024, 8:52:49 PM: ➡️ Uploading backup to http://192.168.1.103:1010/admin...
2024-09-05T20:52:51.667258307-04:00 9/5/2024, 8:52:51 PM: ✔️ Backup uploaded to http://192.168.1.86/admin!
2024-09-05T20:52:51.667510136-04:00 9/5/2024, 8:52:51 PM: ➡️ Updating gravity on http://192.168.1.86/admin...
2024-09-05T20:52:53.165852943-04:00 9/5/2024, 8:52:53 PM: ✔️ Backup uploaded to http://192.168.1.103:1010/admin!
2024-09-05T20:52:53.165885100-04:00 9/5/2024, 8:52:53 PM: ➡️ Updating gravity on http://192.168.1.103:1010/admin...
2024-09-05T20:52:57.164751128-04:00 9/5/2024, 8:52:57 PM: ✔️ Gravity updated on http://192.168.1.86/admin!
2024-09-05T20:52:58.056039552-04:00 9/5/2024, 8:52:58 PM: ✔️ Gravity updated on http://192.168.1.103:1010/admin!
2024-09-05T20:52:58.056296630-04:00 9/5/2024, 8:52:58 PM: ✔️ Success: 2/2 hosts synced.
2024-09-05T20:52:58.056317505-04:00 9/5/2024, 8:52:58 PM: Waiting 15 minutes...

[mattwebbio]

Per the docs: SECONDARY_HOST_1_BASE_URL should be SECONDARY_HOSTS_1_BASE_URL (emphasis on the plural "hosts")

[mike12806]

Oh man - I feel like a dunce. That worked - thank you!

9/5/2024, 9:07:04 PM: ➡️ Signing in to http://192.168.9.3:1010/admin...
2024-09-05T21:07:04.619345705-04:00 9/5/2024, 9:07:04 PM: ✔️ Successfully signed in to http://192.168.9.3:1010/admin!
2024-09-05T21:07:04.620200996-04:00 9/5/2024, 9:07:04 PM: ➡️ Downloading backup from http://192.168.9.3:1010/admin...
2024-09-05T21:07:04.673425584-04:00 9/5/2024, 9:07:04 PM: ✔️ Backup from http://192.168.9.3:1010/admin completed!
2024-09-05T21:07:04.673933154-04:00 9/5/2024, 9:07:04 PM: ➡️ Signing in to http://192.168.1.103:1010/admin...
2024-09-05T21:07:04.675675444-04:00 9/5/2024, 9:07:04 PM: ➡️ Signing in to http://192.168.1.86/admin...
2024-09-05T21:07:04.677220442-04:00 9/5/2024, 9:07:04 PM: ➡️ Signing in to http://192.168.1.53:90/admin...
2024-09-05T21:07:04.720490980-04:00 9/5/2024, 9:07:04 PM: ✔️ Successfully signed in to http://192.168.1.86/admin!
2024-09-05T21:07:04.721067331-04:00 9/5/2024, 9:07:04 PM: ➡️ Uploading backup to http://192.168.1.86/admin...
2024-09-05T21:07:04.744720886-04:00 9/5/2024, 9:07:04 PM: ✔️ Successfully signed in to http://192.168.1.53:90/admin!
2024-09-05T21:07:04.744746350-04:00 9/5/2024, 9:07:04 PM: ➡️ Uploading backup to http://192.168.1.53:90/admin...
2024-09-05T21:07:04.755922921-04:00 9/5/2024, 9:07:04 PM: ✔️ Successfully signed in to http://192.168.1.103:1010/admin!
2024-09-05T21:07:04.756224545-04:00 9/5/2024, 9:07:04 PM: ➡️ Uploading backup to http://192.168.1.103:1010/admin...
2024-09-05T21:07:07.059773547-04:00 9/5/2024, 9:07:07 PM: ✔️ Backup uploaded to http://192.168.1.53:90/admin!
2024-09-05T21:07:07.060452906-04:00 9/5/2024, 9:07:07 PM: ➡️ Updating gravity on http://192.168.1.53:90/admin...
2024-09-05T21:07:07.085157737-04:00 9/5/2024, 9:07:07 PM: ✔️ Backup uploaded to http://192.168.1.86/admin!
2024-09-05T21:07:07.085185019-04:00 9/5/2024, 9:07:07 PM: ➡️ Updating gravity on http://192.168.1.86/admin...
2024-09-05T21:07:08.362290506-04:00 9/5/2024, 9:07:08 PM: ✔️ Backup
uploaded to http://192.168.1.103:1010/admin!
2024-09-05T21:07:08.362314066-04:00 9/5/2024, 9:07:08 PM: ➡️ Updating gravity on http://192.168.1.103:1010/admin...
2024-09-05T21:07:15.915415887-04:00 9/5/2024, 9:07:15 PM: ✔️ Gravity updated on http://192.168.1.53:90/admin!
2024-09-05T21:07:16.005714694-04:00 9/5/2024, 9:07:16 PM: ✔️ Gravity updated on http://192.168.1.103:1010/admin!
2024-09-05T21:07:16.255454495-04:00 9/5/2024, 9:07:16 PM: ✔️ Gravity updated on http://192.168.1.86/admin!
2024-09-05T21:07:16.255504735-04:00 9/5/2024, 9:07:16 PM: ✔️ Success: 3/3 hosts synced.
2024-09-05T21:07:16.261632444-04:00 9/5/2024, 9:07:16 PM: Waiting 15 minutes...