`pRects` parameter of `ID3D12GraphicsCommandList::ClearRenderTargetView` method should be nullable

[odorovskoy]

Its documentation says:

An array of D3D12_RECT structures for the rectangles in the resource view to clear.
If NULL, ClearRenderTargetView clears the entire resource view.

I forked the latest version of zigwin32, changed the type from [*]const RECT to ?[*]const RECT and passed null - works fine.

Investigating a bit further, this parameter has only two attributes in win32json: "Attrs":["In","Const"], so it lacks Optional attribute:

https://github.com/marlersoft/win32json/blob/ca9dd560f598062be334f4b5687764a85de1416c/api/Graphics.Direct3D12.json#L7547-L7561

According to build.json, JSON metadata above is generated from a file at https://www.nuget.org/api/v2/package/Microsoft.Windows.SDK.Win32Metadata/31.0.4-preview. Looks like that file lacks Optional attribute for the parameter in question.

[marler8997]

I'll double check what the latest metadata version marks it as in ILSpy, if it's not marked as optional then we can file a bug upstream.

[marler8997]

Looks like it's fixed in the latest version.

31.0.4-preview:

unsafe void ClearRenderTargetView(
    [In] D3D12_CPU_DESCRIPTOR_HANDLE RenderTargetView,
	[In][Const] float* ColorRGBA,
	[In] uint NumRects,
	[In][Const][NativeArrayInfo(CountParamIndex = 2)] RECT* pRects
);

69.0.7-preview

unsafe void ClearRenderTargetView(
    [In] D3D12_CPU_DESCRIPTOR_HANDLE RenderTargetView,
	[In][Const][NativeArrayInfo(CountConst = 4)] float* ColorRGBA,
	[In] uint NumRects,
	[Optional][In][Const][NativeArrayInfo(CountParamIndex = 2)] RECT* pRects
);

Fix is to get win32json and zigwin32 up-to-date. I do each version one at a time, verify via testing and then release. I got a couple years behind but a couple weekends ago started the update process. I'll see if I can get to this soon.