Skip to content

#(filter) and #(filters) code needs a second look #797

Description

@mtoy-googly-moogly

PR #792 moved the rest of publisher's annotation reading onto a new API but deliberately left this alone — the migration isn't a one-line swap, and the shape of the change felt like yours to decide rather than mine.

After #792 lands ...

Consider moving #(filter) / #(filters) handling onto Malloy's annotation routing API

Publisher filters annotations to specific routes (#(filter) and #(filters)) using hand-rolled prefix matching and an in-house key=value tokenizer — filter.ts on the server side, sdk/components/filter/utils.ts in the SDK.

That code predates the now-formalized annotation routing API in Malloy core (Annotations view, forRoute, parseAsTag, route-aware stable helpers).

Worth a look. Happy to discuss.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions