From 4b6cc53890c2d93b61de1818bd6408f8b70fcef9 Mon Sep 17 00:00:00 2001 From: sriram veeraghanta Date: Tue, 12 May 2026 21:53:00 +0530 Subject: [PATCH] [INFRA-373]: enforce non-empty RUNNER_HMAC_SECRET_KEY Use Helm's `required` function on env.runner_envs.hmac_secret_key so the chart fails fast at render time instead of emitting an empty HMAC secret when the runner is enabled without an external secret. Addresses CodeRabbit review comment on #225. --- .../plane-enterprise/templates/config-secrets/runner-env.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/plane-enterprise/templates/config-secrets/runner-env.yaml b/charts/plane-enterprise/templates/config-secrets/runner-env.yaml index e7c127f0..dc1e07a2 100644 --- a/charts/plane-enterprise/templates/config-secrets/runner-env.yaml +++ b/charts/plane-enterprise/templates/config-secrets/runner-env.yaml @@ -6,7 +6,7 @@ metadata: namespace: {{ .Release.Namespace }} name: {{ .Release.Name }}-runner-secrets stringData: - RUNNER_HMAC_SECRET_KEY: {{ .Values.env.runner_envs.hmac_secret_key | default "" | quote }} + RUNNER_HMAC_SECRET_KEY: {{ required "env.runner_envs.hmac_secret_key must be set when services.runner.enabled=true and external_secrets.runner_env_existingSecret is empty" .Values.env.runner_envs.hmac_secret_key | quote }} {{- end }} --- {{- if .Values.services.runner.enabled }}