Skip to content

Commit f248eef

Browse files
authored
[WARP] Update warp LKG version to use 1.0.17 (#671)
This PR updates the warp version used by the offload test suite to the latest, 1.0.17, from 1.0.15. Compared to 1.0.15, the latest version fixes bugs with reserved resources and other wave operations. Fixes #670 Fixes #610 Fixes #396 Fixes #433
1 parent 2fcc0c9 commit f248eef

6 files changed

Lines changed: 5 additions & 10 deletions

File tree

.github/workflows/windows-amd-clang-warp-preview-d3d12.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,4 @@ jobs:
2020
SKU: windows-amd
2121
TestTarget: check-hlsl-clang-warp-d3d12
2222
OffloadTest-branch: ${{ github.ref }}
23-
LLVM-ExtraCMakeArgs: -DCMAKE_C_COMPILER=clang-cl -DCMAKE_CXX_COMPILER=clang-cl -DOFFLOADTEST_USE_CLANG_TIDY=On -DWARP_VERSION=1.0.15-preview
23+
LLVM-ExtraCMakeArgs: -DCMAKE_C_COMPILER=clang-cl -DCMAKE_CXX_COMPILER=clang-cl -DOFFLOADTEST_USE_CLANG_TIDY=On -DWARP_VERSION=1.0.17

.github/workflows/windows-amd-dxc-warp-preview-d3d12.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,4 @@ jobs:
2121
BuildType: Debug
2222
TestTarget: check-hlsl-warp-d3d12
2323
OffloadTest-branch: ${{ github.ref }}
24-
LLVM-ExtraCMakeArgs: -DCMAKE_C_COMPILER=clang-cl -DCMAKE_CXX_COMPILER=clang-cl -DWARP_VERSION=1.0.15-preview
24+
LLVM-ExtraCMakeArgs: -DCMAKE_C_COMPILER=clang-cl -DCMAKE_CXX_COMPILER=clang-cl -DWARP_VERSION=1.0.17

cmake/modules/Warp.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ function(setup_warp version)
2424
guess_nuget_arch(NUGET_ARCH)
2525

2626
if (version STREQUAL "LKG")
27-
set(version "1.0.15")
27+
set(version "1.0.17")
2828
set(version_description "Latest Known Good for ${NUGET_ARCH} (${version})")
2929
else ()
3030
set(version_description "Custom (${version})")

test/WaveOps/WaveActiveMax.test

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,8 @@ DescriptorSets:
8787
# DirectX driver implementations seem to match SPIR-V, except WARP, which does
8888
# not treat -INF as an identity.
8989

90-
# XFAIL: DirectX && WARP
90+
# XFAIL: arm64 && DirectX && WARP
91+
9192

9293
# CHECK: Name: Nans
9394
# CHECK-NEXT: Format: Float32

test/WaveOps/WaveReadLaneAt.16.test

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,9 +138,6 @@ DescriptorSets:
138138
# Bug https://github.com/llvm/offload-test-suite/issues/351
139139
# XFAIL: Metal
140140

141-
# Bug tracked by https://github.com/llvm/offload-test-suite/issues/396
142-
# XFAIL: DirectX && WARP
143-
144141
# Bug https://github.com/llvm/offload-test-suite/issues/532
145142
# XFAIL: DirectX && QC
146143

test/WaveOps/WaveReadLaneFirst.fp16.test

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -313,9 +313,6 @@ DescriptorSets:
313313
# Bug https://github.com/llvm/offload-test-suite/issues/627
314314
# XFAIL: QC && DirectX
315315

316-
# Bug https://github.com/llvm/offload-test-suite/issues/433
317-
# XFAIL: WARP
318-
319316
# RUN: split-file %s %t
320317
# RUN: %dxc_target -enable-16bit-types -T cs_6_5 -Fo %t.o %t/source.hlsl
321318
# RUN: %offloader %t/pipeline.yaml %t.o

0 commit comments

Comments
 (0)