fix: avoid unnecessary feedback sound when unmuting sink#1171
Conversation
When setting volume, the system was calling setMute with feedback enabled, which could trigger a feedback sound incorrectly. This change introduces setMuteWithoutFeedback to suppress the feedback sound during volume updates, ensuring feedback is only played when the user explicitly toggles mute. Log: Fixed unexpected feedback sound when adjusting volume while sink is muted Influence: 1. Test volume adjustment while sink is muted - verify no feedback sound plays 2. Test toggling mute via UI - verify feedback sound plays correctly 3. Test volume adjustment when not muted - verify normal behavior 4. Verify mute state persistence after volume changes fix: 修复取消静音时不必要的反馈音 调整音量时，系统调用了带反馈的 setMute，可能在静音状态下错误触发反馈音。 此更改引入 setMuteWithoutFeedback 以在音量更新时抑制反馈音，确保仅当用户 明确切换静音时才播放反馈音。 Log: 修复调整音量时静音状态下意外播放反馈音的问题 Influence: 1. 测试在静音状态下调整音量 - 验证无反馈音播放 2. 测试通过界面切换静音 - 验证反馈音正常播放 3. 测试非静音状态下调整音量 - 验证行为正常 4. 验证音量调整后静音状态正确保持 PMS: BUG-368461
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Hi @52cyb. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 52cyb, fly602 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: unstable) |
3 participants
When setting volume, the system was calling setMute with feedback enabled, which could trigger a feedback sound incorrectly. This change introduces setMuteWithoutFeedback to suppress the feedback sound during volume updates, ensuring feedback is only played when the user explicitly toggles mute.
Log: Fixed unexpected feedback sound when adjusting volume while sink is muted
Influence:
fix: 修复取消静音时不必要的反馈音
调整音量时，系统调用了带反馈的 setMute，可能在静音状态下错误触发反馈音。
此更改引入 setMuteWithoutFeedback 以在音量更新时抑制反馈音，确保仅当用户
明确切换静音时才播放反馈音。
Log: 修复调整音量时静音状态下意外播放反馈音的问题
Influence:
PMS: BUG-368461