[firstmate#1195] fix(spawn): forward CLAUDE_CONFIG_DIR to claude crewmates

[github-actions]

Decision needed - firstmate#1195

PR review by lucashalbert · merge-ready

fix(spawn): forward CLAUDE_CONFIG_DIR to claude crewmates

Situation

• Compliance: pass
• Tests: green
• Configured checks: PR must be raised via no-mistakes (compliance: pass), Behavior portable parallel 1 (informational: pass), Behavior portable parallel 2 (informational: pass), Behavior portable serial (informational: pass), Behavior timing aggregate (informational: pass), Lint shell scripts (informational: pass), Repo invariants (informational: pass), Stock macOS Bash snapshot compatibility (informational: pass), Test coverage guard (informational: pass), Behavior tests (Herdr) (test: pass)
• Freshness: complete target observation as of 2026-07-29T00:09:37Z
• Notes: compliance=pass tests=green

Related work

Note

Related-work context is truncated (comparison_incomplete): comparison across open pull requests is incomplete, so a relation may be missed; this says nothing about the target itself. The candidate list, shared paths, and references are advisory display only and never an overlap or action gate.

Showing 10 of 40 deterministic related candidates, strongest relations first; the remaining matches are omitted by the deliberate display/model context cap, not by missing comparison evidence.

• kunchenguid/firstmate#198 - feat: verify devin CLI as a harness adapter - exact shared path: bin/fm-spawn.sh
• kunchenguid/firstmate#218 - fix(spawn): capture worktree lease by repo-identity, not treehouse root - exact shared path: bin/fm-spawn.sh
• kunchenguid/firstmate#264 - fix: record real leased worktree in fm-spawn meta; harden fm-teardown - exact shared paths: bin/fm-spawn.sh, tests/fm-spawn-dispatch-profile.test.sh
• kunchenguid/firstmate#280 - feat(harness): add cursor and hermes verified adapters - exact shared path: bin/fm-spawn.sh
• kunchenguid/firstmate#290 - fix: harness detection, backend binary check, FM_PROJECTS_OVERRIDE drift - exact shared path: bin/fm-spawn.sh
• kunchenguid/firstmate#298 - feat(downstream): default firstmate self-changes to local-only on downstream instances - exact shared path: bin/fm-spawn.sh
• kunchenguid/firstmate#324 - fix(spawn): acquire crew worktrees via treehouse get --lease - exact shared paths: bin/fm-spawn.sh, tests/fm-spawn-dispatch-profile.test.sh
• kunchenguid/firstmate#344 - codex: bypass hook trust in spawn template - exact shared paths: bin/fm-spawn.sh, tests/fm-spawn-dispatch-profile.test.sh
• kunchenguid/firstmate#357 - Fix fm-spawn help parsing - exact shared path: bin/fm-spawn.sh
• kunchenguid/firstmate#360 - fix(backends): pass provider API keys through to cmux crewmate spawns - exact shared path: bin/fm-spawn.sh

Advisory context only. Shared paths and references are not an auto-merge overlap gate.

Auto-merge criteria

Note

Read-only preflight from the authoritative auto-merge evaluator. A displayed MET result never authorizes a merge: Wheelhouse re-evaluates every gate and performs G7 immediately before acting.

Scope

• ✅ MET Scope - merge-ready PR review - kind=pr-review bucket=merge-ready

Safety

• ✅ MET Safety - complete healthy scan - repo scan is ok, complete, and mergeability settled
• ✅ MET Safety - target PR is open - target PR is open and unmerged
• ✅ MET Safety - no per-PR auto-merge opt-out - wheelhouse:no-auto-merge is absent
• ✅ MET Safety - head SHA unchanged - scan and live head eedd89b1

G0 (repo)

• ✅ MET G0 - repository auto-merge enabled - enabled by effective repository policy
• ⚪ UNAVAILABLE G0 - default-branch VISION.md present - VISION.md missing or unreadable on the default branch

G1 (card)

• ✅ MET G1 - trusted unique decision card - trusted unique machine-created card [firstmate#1195] fix(spawn): forward CLAUDE_CONFIG_DIR to claude crewmates #1831
• ✅ MET G1 - card published after triage - decision controls are published
• ⚪ UNAVAILABLE G1 - exclusive card claim - claim is acquired and revalidated only at the act boundary

G2 (files)

• ✅ MET G2 - complete immutable file list - 2 immutable changed path entries read
• ✅ MET G2 - workflow and security exclusions clear - no unconditional workflow/security/governance exclusions

G3 (author)

• ✅ MET G3 - non-maintainer human contributor - lucashalbert is a non-maintainer human
• ❌ UNMET G3 - prior merged contribution in this repo - G3 author lucashalbert has no prior merged PR in firstmate

G4 (checks)

• ✅ MET G4 - configured checks green - comp=pass tests=green (merge-ready)
• ✅ MET G4 - PR mergeable - live mergeable is MERGEABLE
• ✅ MET G4 - merge state clean - live merge state is CLEAN

G5 (size)

• ✅ MET G5 - changed-file limit - 2 changed files <= 20
• ✅ MET G5 - changed-line limit - 67 changed lines <= 1000

G6 (triage + behavior)

• ✅ MET G6 - automatic triage credential configured - model credential is configured; card triage eligibility is evaluated separately
• ✅ MET G6 - successful triage for current head - successful triage for head eedd89b1
• ✅ MET G6 - top-level recommendation is merge - explicit merge recommendation
• ⚪ UNAVAILABLE G6 - eligible behavior class - class B restoration evidence unavailable
• ✅ MET G6 - existing/default behavior unchanged - no existing/default behavior change
• ✅ MET G6 - class C is opt-in and default-off - not applicable to class B
• VISION.md-dependent checks - needs VISION.md
  • ⚪ UNAVAILABLE G6 - behavior aligns with VISION.md - not evaluated because a trusted default-branch VISION.md is required
  • ⚪ UNAVAILABLE G6 - behavior verdict recommends merge - not evaluated because a trusted default-branch VISION.md is required
  • ⚪ UNAVAILABLE G6 - verdict uses current VISION.md revision - not evaluated because a trusted default-branch VISION.md is required
  • ⚪ UNAVAILABLE G6 - verdict uses current base revision - not evaluated because a trusted default-branch VISION.md is required

G7 (final gate)

• ⚪ UNAVAILABLE G7 - immediate live recheck and manual merge gate - runs only immediately before merge: card claim, VISION, head/base, mergeability, checks, opt-out label, and unchanged manual workflow gate

Triage

• Summary: Forward firstmate's CLAUDE_CONFIG_DIR onto the claude crewmate launch command so daemon-spawned panes authenticate with the correct credential store when a non-default config dir is set.
• Product implications: Owner discussion: touches crewmate spawn mechanics for multi-subscription setups; scope is tightly bounded (claude harness only, non-empty CLAUDE_CONFIG_DIR only) and the default single-store path is entirely unaffected.

Recommended action

• Agent recommendation: merge
• Reason: Narrow, well-evidenced correctness fix: guards on HARNESS=claude and non-empty value, uses shell_quote, pins CLAUDE_CONFIG_DIR empty in run_spawn to isolate existing tests, adds three targeted unit tests covering set/unset/non-claude cases, and all ten configured CI checks pass.

From the current admitted automatic triage assessment for this exact revision. Tick Accept recommendation to apply it - it is advisory and never an auto-merge authorization.

Your decision

Tick one box for a quick call, or reply with a slash-command (/merge, /close, /decline <reason>, /hold, /comment <text>, /request-changes <text>):

• Accept recommendation
• Merge it
• Close / decline
• Investigate - deep code-grounded review (leaves this card open)
• Hold - I'll handle this manually

_{Only the repository owner can drive this decision - everyone else's edits and comments are ignored.}

[github-actions]

Agent triage event finished with consumer.committed.

[github-actions]

Triage result projected.

[github-actions]

[github-actions]

Merged firstmate#1195 (squash).