Revert "fix: make FormCtaClicked.deepLinkUrl nullable so CTA events fire even without a deep link"

This reverts commit 7919856.

Author: evan-masseau

sdk/forms-core/src/main/java/com/klaviyo/forms/FormLifecycleEvent.kt

@@ -41,12 +41,12 @@ sealed interface FormLifecycleEvent {
      * Triggered when a user taps a call-to-action (CTA) button in the form.
      *
      * @property buttonLabel The text label of the CTA button.
-     * @property deepLinkUrl The deep link URI configured for the CTA, or null if not configured.
+     * @property deepLinkUrl The deep link URI configured for the CTA.
      */
     data class FormCtaClicked(
         override val formId: String,
         override val formName: String,
         val buttonLabel: String,
-        val deepLinkUrl: Uri?
+        val deepLinkUrl: Uri
     ) : FormLifecycleEvent
 }

sdk/forms/src/main/java/com/klaviyo/forms/bridge/KlaviyoNativeBridge.kt

@@ -121,14 +121,14 @@ internal class KlaviyoNativeBridge : NativeBridge {
      * We alleviate this race condition by postponing till next activity resumes if current activity is null.
      */
     private fun deepLink(message: OpenDeepLink) {
-        val deepLinkUri = message.route?.let { it.toUri() }
+        val deepLinkUri = message.route?.toUri()
 
-        if (deepLinkUri != null) {
-            DeepLinking.handleDeepLink(deepLinkUri)
-        } else {
-            Registry.log.verbose("Form CTA with no Android route configured: ${message.formId}")
+        if (deepLinkUri == null) {
+            Registry.log.warning("Form CTA with no Android route configured: ${message.formId}")
+            return
         }
 
+        DeepLinking.handleDeepLink(deepLinkUri)
         invokeFormLifecycleHandler(
             FormLifecycleEvent.FormCtaClicked(
                 formId = message.formId,

sdk/forms/src/test/java/com/klaviyo/forms/bridge/KlaviyoNativeBridgeTest.kt

@@ -30,7 +30,6 @@ import org.json.JSONException
 import org.json.JSONObject
 import org.junit.After
 import org.junit.Assert.assertEquals
-import org.junit.Assert.assertNull
 import org.junit.Before
 import org.junit.Test
 
@@ -282,7 +281,7 @@ internal class KlaviyoNativeBridgeTest : BaseTest() {
     }
 
     @Test
-    fun `openDeepLink with empty android route emits lifecycle event with null deepLinkUrl and does not navigate`() {
+    fun `openDeepLink with empty android route skips lifecycle callback and does not navigate`() {
         /**
          * @see com.klaviyo.forms.bridge.KlaviyoNativeBridge.deepLink
          */
@@ -291,29 +290,20 @@ internal class KlaviyoNativeBridgeTest : BaseTest() {
               "type": "openDeepLink",
               "data": {
                 "ios": "klaviyotest://settings",
-                "android": "",
-                "formId": "abc",
-                "formName": "My Form",
-                "buttonLabel": "Click Me"
+                "android": ""
               }
             }
         """.trimIndent()
 
         mockkObject(DeepLinking)
         every { DeepLinking.handleDeepLink(any<Uri>()) } returns Unit
 
-        val events = mutableListOf<FormLifecycleEvent>()
-        val callback = FormLifecycleHandler { event -> events.add(event) }
-        Registry.register<FormLifecycleHandler>(callback)
+        val mockLifecycleHandler = mockk<FormLifecycleHandler>(relaxed = true)
+        Registry.register<FormLifecycleHandler>(mockLifecycleHandler)
 
         postMessage(emptyAndroidMessage)
 
-        assertEquals(1, events.size)
-        val ctaEvent = events[0] as FormLifecycleEvent.FormCtaClicked
-        assertEquals("abc", ctaEvent.formId)
-        assertEquals("My Form", ctaEvent.formName)
-        assertEquals("Click Me", ctaEvent.buttonLabel)
-        assertNull(ctaEvent.deepLinkUrl)
+        verify(exactly = 0) { mockLifecycleHandler.onFormLifecycleEvent(any()) }
         verify(exactly = 0) { DeepLinking.handleDeepLink(any<Uri>()) }
 
         Registry.unregister<FormLifecycleHandler>()