fix: treat empty/missing android deep link as no-op instead of crash (#415)

* fix: treat empty/missing android deep link as no-op instead of crash

When a form CTA is configured without an Android route (iOS-only or no URL),
the JS bridge sends an empty string for the android field. Previously this
threw an IllegalStateException in getDeepLink(), causing an ERROR log and
skipping any downstream handling. Now the route is nullable — an empty or
absent android field decodes to null, and deepLink() logs a warning and
skips navigation instead of crashing.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

* test: Use any() matcher for log message to avoid brittle assertion

Verify log level rather than exact message content, consistent with
other test files in the project.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

---------

Co-authored-by: Claude Sonnet 4.6 <[email protected]>

Author: 2 people

sdk/forms/src/main/java/com/klaviyo/forms/bridge/KlaviyoNativeBridge.kt

@@ -114,7 +114,10 @@ internal class KlaviyoNativeBridge() : NativeBridge {
      * There is a brief window between our overlay activity pausing and the next activity resuming.
      * We alleviate this race condition by postponing till next activity resumes if current activity is null.
      */
-    private fun deepLink(message: OpenDeepLink) = DeepLinking.handleDeepLink(message.route.toUri())
+    private fun deepLink(message: OpenDeepLink) {
+        message.route?.let { DeepLinking.handleDeepLink(it.toUri()) }
+            ?: Registry.log.warning("Deep link CTA with no Android route configured")
+    }
 
     /**
      * Instruct presentation manager to dismiss the form overlay activity

sdk/forms/src/main/java/com/klaviyo/forms/bridge/NativeBridgeMessage.kt

@@ -56,10 +56,10 @@ internal sealed class NativeBridgeMessage {
     /**
      * Sent from the onsite-in-app-forms when a deep link is opened
      *
-     * @param route The deep link route to be opened (usually a URL)
+     * @param route The deep link route to be opened (usually a URL), or null if no Android route is configured
      */
     data class OpenDeepLink(
-        val route: String
+        val route: String?
     ) : NativeBridgeMessage()
 
     /**
@@ -164,14 +164,9 @@ internal sealed class NativeBridgeMessage {
         }
 
         /**
-         * Parse out the android platform deep link
+         * Parse out the android platform deep link, returning null if not present or empty
          */
-        private fun JSONObject.getDeepLink(): String {
-            val routeString = optString("android")
-            if (routeString.isNullOrEmpty()) {
-                throw IllegalStateException("No android deeplink found in js payload")
-            }
-            return routeString
-        }
+        private fun JSONObject.getDeepLink(): String? =
+            optString("android").takeIf { it.isNotEmpty() }
     }
 }

sdk/forms/src/test/java/com/klaviyo/forms/bridge/KlaviyoNativeBridgeTest.kt

@@ -273,6 +273,30 @@ internal class KlaviyoNativeBridgeTest : BaseTest() {
         verify { DeepLinking.handleDeepLink(mockUri) }
     }
 
+    @Test
+    fun `openDeepLink with empty android route logs warning and does not navigate`() {
+        /**
+         * @see com.klaviyo.forms.bridge.KlaviyoNativeBridge.deepLink
+         */
+        val emptyAndroidMessage = """
+            {
+              "type": "openDeepLink",
+              "data": {
+                "ios": "klaviyotest://settings",
+                "android": ""
+              }
+            }
+        """.trimIndent()
+
+        mockkObject(DeepLinking)
+        every { DeepLinking.handleDeepLink(any<Uri>()) } returns Unit
+
+        postMessage(emptyAndroidMessage)
+
+        verify(exactly = 0) { DeepLinking.handleDeepLink(any<Uri>()) }
+        verify { spyLog.warning(any(), null) }
+    }
+
     @Test
     fun `formDisappeared triggers close`() {
         /**

sdk/forms/src/test/java/com/klaviyo/forms/bridge/NativeBridgeMessageTest.kt

@@ -222,7 +222,7 @@ class NativeBridgeMessageTest : BaseTest() {
     }
 
     @Test
-    fun `deeplink does not have android field, throws error`() {
+    fun `deeplink does not have android field, returns OpenDeepLink with null route`() {
         val deeplinkMessage = """
             {
               "type": "openDeepLink",
@@ -232,12 +232,26 @@ class NativeBridgeMessageTest : BaseTest() {
             }
         """.trimIndent()
 
-        every { Registry.log.error(any(), any<Throwable>()) } just Runs
+        val result = NativeBridgeMessage.decodeWebviewMessage(deeplinkMessage) as NativeBridgeMessage.OpenDeepLink
 
-        // Act & Assert
-        assertThrows(IllegalStateException::class.java) {
-            NativeBridgeMessage.decodeWebviewMessage(deeplinkMessage)
-        }
+        assertEquals(NativeBridgeMessage.OpenDeepLink(route = null), result)
+    }
+
+    @Test
+    fun `deeplink with empty android field returns OpenDeepLink with null route`() {
+        val deeplinkMessage = """
+            {
+              "type": "openDeepLink",
+              "data": {
+                "ios": "klaviyotest://settings",
+                "android": ""
+              }
+            }
+        """.trimIndent()
+
+        val result = NativeBridgeMessage.decodeWebviewMessage(deeplinkMessage) as NativeBridgeMessage.OpenDeepLink
+
+        assertEquals(NativeBridgeMessage.OpenDeepLink(route = null), result)
     }
 
     @Test