fix: closeForm passes no args, bump close timeout to 600ms

- Update JS closeForm to pass empty formId (close all forms)
- Remove unused formId vararg from KlaviyoJsBridge.closeForm()
- Bump CLOSE_TIMEOUT from 500ms to 600ms for more buffer over
  the ~350ms JS close animation
- Add Uri.parse mock to FormLifecycleCallbackTest setup

Part of MAGE-287

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Author: evan-masseau

sdk/forms/src/main/assets/klaviyo-js-bridge.js

@@ -93,19 +93,16 @@ window.openForm = function (formId) {
 }
 
 /**
- * Close a Klaviyo form by formId, or any currently open forms
+ * Close any currently open Klaviyo forms
  *
- * @param {string} formId
  * @returns {boolean}
  */
 window.closeForm = function (formId) {
     document.head.dispatchEvent(
         new CustomEvent(
             'closeForm',
             {
-                detail: {
-                    formId: formId
-                }
+                detail: {}
             }
         )
     )

sdk/forms/src/main/java/com/klaviyo/forms/bridge/KlaviyoJsBridge.kt

@@ -46,10 +46,7 @@ internal class KlaviyoJsBridge : JsBridge {
         formId
     )
 
-    override fun closeForm() = evaluateJavascript(
-        HelperFunction.closeForm,
-        ""
-    )
+    override fun closeForm() = evaluateJavascript(HelperFunction.closeForm)
 
     override fun profileMutation(profile: ImmutableProfile) = evaluateJavascript(
         HelperFunction.profileMutation,

sdk/forms/src/main/java/com/klaviyo/forms/presentation/KlaviyoPresentationManager.kt

@@ -140,9 +140,9 @@ internal class KlaviyoPresentationManager() : PresentationManager {
         /**
          * Grace period to close a form with animation, before we just dismiss
          *  the overlay activity without waiting for formDisappeared event.
-         *  Must exceed the JS close animation duration (~400ms) or the activity
-         *  teardown will kill the animation before formDisappeared is sent.
+         *  Must exceed the JS close animation duration (~350ms) with a buffer for signaling delays
+         *  or else teardown will kill the webview's rendering before formDisappeared can be sent.
          */
-        private const val CLOSE_TIMEOUT = 500L
+        private const val CLOSE_TIMEOUT = 600L
     }
 }

sdk/forms/src/test/java/com/klaviyo/forms/FormLifecycleCallbackTest.kt

@@ -1,5 +1,6 @@
 package com.klaviyo.forms
 
+import android.net.Uri
 import com.klaviyo.analytics.Klaviyo
 import com.klaviyo.analytics.linking.DeepLinking
 import com.klaviyo.core.Registry
@@ -10,6 +11,7 @@ import com.klaviyo.forms.presentation.PresentationState
 import io.mockk.every
 import io.mockk.mockk
 import io.mockk.mockkObject
+import io.mockk.mockkStatic
 import io.mockk.unmockkAll
 import io.mockk.verify
 import org.junit.After
@@ -34,6 +36,8 @@ internal class FormLifecycleCallbackTest : BaseTest() {
         super.setup()
         every { mockPresentationManager.presentationState } returns PresentationState.Presented
         Registry.register<PresentationManager>(mockPresentationManager)
+        mockkStatic(Uri::class)
+        every { Uri.parse(any()) } returns mockk(relaxed = true)
         nativeBridge = KlaviyoNativeBridge()
     }
 

sdk/forms/src/test/java/com/klaviyo/forms/bridge/KlaviyoJsBridgeTest.kt

@@ -216,7 +216,7 @@ class KlaviyoJsBridgeTest : BaseTest() {
 
         verify {
             jsEvaluator.evaluateJavascript(
-                eq("""window.closeForm("")"""),
+                eq("""window.closeForm()"""),
                 any()
             )
         }

sdk/forms/src/test/java/com/klaviyo/forms/presentation/KlaviyoPresentationManagerTest.kt

@@ -225,7 +225,7 @@ class KlaviyoPresentationManagerTest : BaseTest() {
         verify(exactly = 0) { mockWebViewClient.detachWebView() }
         verify(exactly = 0) { mockOverlayActivity.finish() }
 
-        staticClock.execute(500L)
+        staticClock.execute(600L)
 
         verify(exactly = 1) { mockWebViewClient.detachWebView() }
         verify(exactly = 1) { mockOverlayActivity.finish() }