Improve History View

[karanshukla]

Right now its massive and empty, we should add hints somewhere that you can press esc to exit, and maybe even copy events to a clipboard with a shortcut? Needs hints and hints!

[karanshukla]

Spec — History view UX pass

Context

The original pager (9868c51, Jul 22) was a bare title + scroll area. The follow-up 35f40d5 (Jul 23) added a footer hint line, title/meta/column-header, and aligned timestamps. This issue was filed Jul 26 — so the footer does exist today, but:

• It's a single dim-grey #484f58 line at the very bottom (height: 1, dock: bottom) — easy to miss, no visual weight.
• The "massive and empty" feel comes from 4 stacked chrome rows (title + meta + column-header + footer) on a full-screen overlay — heavy framing relative to data density, especially with few events.
• The only interactions are scroll + dismiss. No way to act on an event (copy, inspect, filter).

Goals (from the issue)

1. Discoverable exit hint — Esc/q to close should be unmissable, not buried in a grey footer.
2. Copy events to clipboard — with a shortcut.

Non-goals

• Don't rewrite the pager architecture. The ModalScreen + ScrollableContainer + format_history_rows core is sound.
• Don't add filters/type-selection in this pass (separate issue — the meta summary line already hints at categories).

---

Design

1. Replace the dim footer with Textual's native Footer widget

Drop the custom #history-footer Static and yield Textual's Footer instead. It renders a proper key-binding bar at the bottom — brighter, with the bound keys highlighted — and is the idiomatic place a Textual user looks for shortcuts. The BINDINGS list already exists; promoting the bindings to show=True makes them appear in the Footer automatically.

from textual.widgets import Footer

BINDINGS = [
    Binding("escape,q", "dismiss", "Close", priority=True),
    Binding("enter", "copy_row", "Copy row"),
    Binding("c", "copy_all", "Copy all"),
    Binding("slash", "toggle_summary", "Summary"),  # see §3
]

The Footer also fixes the discoverability problem structurally — it's where TUI users expect hints, and it stays visible regardless of scroll position.

Note on enter: the current binding closes the screen on Enter. That's surprising (Enter usually "opens/acts" on a selected row, not closes a view). Move close to Esc/q only, and repurpose Enter → copy the focused/selected row. This is a small breaking change but matches the issue's intent ("copy events with a shortcut") and standard list UX.

2. Copy-to-clipboard (no new dependency)

Textual 8.2.7 ships app.copy_to_clipboard(text) natively — verified:

>>> App.copy_to_clipboard
<function App.copy_to_clipboard(self, text: str) -> None>

Two copy actions:

• Enter → copy selected row — copies the focused event as a single line: <iso_timestamp>\t<event>\t<weight>\t<pet>\t<robot>. Shows a transient #3fb950 "Copied 1 event" confirmation in the title line (see §4).
• c → copy all — copies every loaded event (TSV, one per line) to the clipboard. Confirms with Copied N events.

TSV (not CSV) because it pastes cleanly into a spreadsheet cell-per-column without quoting headaches, and matches how the rows are already laid out.

Selection model

Rows are currently bare Static widgets with no focus state. To make Enter meaningful, promote the scroll container's children to focusable rows and track the focused index. Two options:

Option	Approach	Trade-off
A — native focus (recommended)	Make each row a focusable Static subclass (or use ListView/OptionList). Textual handles ↑/↓ focus movement for free; Enter reads self.focused.	Smallest code; arrow keys "just work"; matches Textual idiom.
B — manual index	Keep Static rows, track _selected, handle ↑/↓/Home/End/PgUp/PgDn manually in on_key.	More code; must re-implement scroll-into-view; easier to regress.

Recommend A. If OptionList is used, copy-on-select (Enter) and visual highlighting of the selected row come for free. The current row Text styling can move into the Option's prompt.

3. Reduce visual weight (address "massive")

Three docked header rows is a lot. Collapse to two:

• Line 1 (title): Activity history — <robot> · N events · <date range> — merge the current title + meta into one, dropping the separate meta line. The event-type summary (5 clean · 3 cat visits) is nice-to-have but secondary; move it behind a toggle (/ key → "Summary") so the default view is data-first, or drop it entirely if it's not earning its row.
• Line 2 (column header): keep TIME / EVENT — it anchors alignment.

This reclaims one row of vertical space and removes the "stacked bars" look that reads as "empty chrome."

4. Transient confirmation feedback

A dedicated toast is overkill for a 1-action screen. Instead, flash the title line with the copy result for ~1.2s, then restore it:

from asyncio import sleep

async def action_copy_all(self) -> None:
    self.app.copy_to_clipboard(self._as_tsv(self._acts))
    await self._flash(f"Copied {len(self._acts)} events to clipboard")

async def _flash(self, msg: str) -> None:
    title = self.query_one("#history-title", Static)
    original = title.renderable
    title.update(Text(msg, style="bold #3fb950"))
    await sleep(1.2)
    title.update(original)

Green for success, red (#f85149) if the clipboard write fails (Textual swallows clipboard errors on platforms without a clipboard daemon — surface it rather than fail silently).

---

Files

• asher/history_view.py — main work:
  • Replace #history-footer Static with Footer() in compose().
  • Promote BINDINGS to show=True; add copy_row / copy_all actions + bindings.
  • Make rows focusable (Option A: subclass or switch to OptionList).
  • Add _as_tsv() helper + _flash() confirmation.
  • Merge title+meta into one line; drop or toggle the summary.
• asher/commands/__init__.py — HistoryCommand unchanged (still pushes HistoryScreen); no signature change.
• tests/test_history_view.py — add:
  • action_copy_all writes expected TSV to clipboard (assert app.copy_to_clipboard called with the right text).
  • action_copy_row copies the focused row's TSV.
  • Esc/q still dismiss; Enter now copies (regression: it used to dismiss — document the change).
  • Footer is present and shows the bound actions.
  • _flash restores the title after the timeout.
• CLAUDE.md — update the history_view.py description + key-methods note for the new actions.

Open questions (resolve before implementing)

1. Drop the summary line entirely, or keep it behind a toggle? The event-type breakdown (5 clean · 3 cat visits) is genuinely useful for spotting patterns — but it's a second header row. Recommendation: keep it inline in the title when there's room (short robot name), drop when the title would wrap. Avoids a toggle and its extra keybinding.
2. Enter breaking change — repurposing Enter from "close" to "copy row" is the right call for a list view, but anyone who learned Enter closes will be surprised. Worth a one-line changelog note. Esc/q still close. Acceptable?
3. Copy format — TSV (recommended, pastes into spreadsheets) vs CSV (matches the export command). Lean TSV for clipboard, CSV is already covered by export.

Verification

• uv run poe check — ruff + format + mypy + pytest green.
• Manual: history → footer shows Close/Copy row/Copy all; ↑/↓ moves a visible selection; Enter copies one row, c copies all, title flashes green; Esc/q close; layout no longer feels "massive" (2 header rows + footer).