Skip to content

fix issue on GeneralDichotomy initial weights#208

Merged
odow merged 3 commits into
jump-dev:masterfrom
smbct:generaldichotomy_fix_initweights
Jul 2, 2026
Merged

fix issue on GeneralDichotomy initial weights#208
odow merged 3 commits into
jump-dev:masterfrom
smbct:generaldichotomy_fix_initweights

Conversation

@smbct

@smbct smbct commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

This commit solves an issue on the weight update procedure in GeneralDichotomy.
Initial weights could be previously wrongly updated, which makes the bensolve vlp instance test fails (http://www.bensolve.org/).

The method should be able to find at least the four upper image points:

Bensolve test instance

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.64%. Comparing base (b71397a) to head (0fa92ef).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
- Coverage   99.64%   99.64%   -0.01%     
==========================================
  Files          15       15              
  Lines        1421     1414       -7     
==========================================
- Hits         1416     1409       -7     
  Misses          5        5              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@odow odow merged commit a831cdd into jump-dev:master Jul 2, 2026
6 checks passed
@odow

odow commented Jul 2, 2026

Copy link
Copy Markdown
Member

I don't know the algorithm well enough to notice these sorts of details. But in my experience, you cannot have too many test cases!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants