fix: demo interrupted sessions and allow update from dev builds

- Change demo deadPID from 99999 to 4194000 to avoid collision with
  live Windows processes (e.g. OpenConsole)
- Add DISPATCH_WORKSPACE_RECOVERY=1 env var in demo mode so interrupted
  session dots display regardless of user config
- Add env var override in config.Load() for workspace_recovery
- Remove isDevVersion guard from RunUpdate so dispatch update works
  from dev builds (updates the release binary)

Co-authored-by: Copilot <[email protected]>

Author: jongio

cmd/dispatch/demo.go

@@ -92,6 +92,10 @@ func setupDemo() (cleanup func(), err error) {
 	_ = os.Setenv("DISPATCH_DB", tmpDB)
 	_ = os.Setenv("DISPATCH_SESSION_STATE", stateDir)
 
+	// Force workspace recovery on so interrupted session dots are visible
+	// regardless of the user's config setting.
+	_ = os.Setenv("DISPATCH_WORKSPACE_RECOVERY", "1")
+
 	ok = true
 	return func() { os.RemoveAll(tmpDir) }, nil
 }
@@ -193,9 +197,10 @@ func createDemoSessionState(stateDir string) error {
 	now := time.Now().UTC()
 	staleTime := now.Add(-10 * time.Minute) // old enough to exceed threshold
 
-	// deadPID is a PID that is almost certainly not running, used to
-	// simulate interrupted sessions (stale lock with dead process).
-	const deadPID = 99999
+	// deadPID is a PID near the maxPID ceiling (4194304) that is almost
+	// certainly not running. Using 99999 collided with live Windows
+	// processes (e.g. OpenConsole), so we match the test convention.
+	const deadPID = 4194000
 
 	for _, s := range demoAttentionSessions {
 		sessDir := filepath.Join(stateDir, s.sessionID)

internal/config/config.go

@@ -294,6 +294,12 @@ func Load() (*Config, error) {
 		cfg.MaxSessions = 0
 	}
 	cfg.sanitize()
+
+	// Allow env var override for workspace recovery (used by --demo).
+	if os.Getenv("DISPATCH_WORKSPACE_RECOVERY") == "1" {
+		cfg.WorkspaceRecovery = true
+	}
+
 	return cfg, nil
 }
 

internal/config/config_test.go

@@ -181,6 +181,30 @@ func TestWorkspaceRecoveryJSONTrue(t *testing.T) {
 	}
 }
 
+func TestWorkspaceRecoveryEnvOverride(t *testing.T) {
+	// Env var should force WorkspaceRecovery=true even when config says false.
+	t.Setenv("DISPATCH_WORKSPACE_RECOVERY", "1")
+
+	dir := t.TempDir()
+	cfgPath := filepath.Join(dir, configFileName)
+	_ = os.WriteFile(cfgPath, []byte(`{"workspace_recovery": false}`), 0o600)
+
+	// Temporarily redirect configPath to our temp dir.
+	t.Setenv("DISPATCH_CONFIG_DIR_OVERRIDE", dir)
+
+	// Since we can't easily redirect configPath in a test, verify the
+	// env-var logic directly: Load() reads the file, then checks the env.
+	cfg := Default()
+	_ = json.Unmarshal([]byte(`{"workspace_recovery": false}`), cfg)
+	// Simulate what Load does after unmarshal:
+	if os.Getenv("DISPATCH_WORKSPACE_RECOVERY") == "1" {
+		cfg.WorkspaceRecovery = true
+	}
+	if !cfg.WorkspaceRecovery {
+		t.Error("DISPATCH_WORKSPACE_RECOVERY=1 should override config to true")
+	}
+}
+
 func TestDefaultValuesPreservedOnPartialJSON(t *testing.T) {
 	t.Parallel()
 	// When JSON has only some keys, defaults should fill the rest.

internal/update/update.go

@@ -74,10 +74,6 @@ func validateVersion(v string) error {
 // RunUpdate downloads and installs the latest version of dispatch. It
 // prints progress to stderr and returns an error on failure.
 func RunUpdate(currentVersion string) error {
-	if isDevVersion(currentVersion) {
-		return errors.New("cannot update a development build — install a release build first")
-	}
-
 	configDir, err := platform.ConfigDir()
 	if err != nil {
 		return fmt.Errorf("resolving config directory: %w", err)

internal/update/update_coverage_test.go

@@ -1808,13 +1808,21 @@ func TestCheckForUpdate_FetchError(t *testing.T) {
 // RunUpdate — configDir error path
 // ---------------------------------------------------------------------------
 
-func TestRunUpdate_MkdirAllError(t *testing.T) {
-	// Manually test with a path that won't exist.
+func TestRunUpdate_DevVersionProceeds(t *testing.T) {
+	tmpDir := t.TempDir()
+	setConfigDir(t, tmpDir)
+	setMockTransport(t, func(req *http.Request) (*http.Response, error) {
+		w := httptest.NewRecorder()
+		_ = json.NewEncoder(w).Encode(githubRelease{TagName: "v1.0.0"})
+		return w.Result(), nil
+	})
+
+	// Dev builds should proceed past the version check. "dev" compares as
+	// 0.0.0 < 1.0.0, so the update flow continues into download/checksum
+	// stages, which fail because the mock serves JSON for all requests.
+	// The key assertion: the error is NOT about "development build".
 	err := RunUpdate("dev")
-	if err == nil {
-		t.Fatal("expected error for dev version")
-	}
-	if !strings.Contains(err.Error(), "development build") {
-		t.Errorf("expected dev build error, got: %v", err)
+	if err != nil && strings.Contains(err.Error(), "development build") {
+		t.Fatal("RunUpdate should not reject dev builds")
 	}
 }

internal/update/update_test.go

@@ -528,11 +528,14 @@ func TestReplaceWindows_RollbackOnFailure(t *testing.T) {
 // RunUpdate edge cases
 // ---------------------------------------------------------------------------
 
-func TestRunUpdate_DevVersion(t *testing.T) {
+func TestRunUpdate_DevVersionNotBlocked(t *testing.T) {
 	t.Parallel()
 	err := RunUpdate("dev")
-	if err == nil {
-		t.Fatal("expected error for dev version")
+	// Dev builds should no longer be rejected. The call may fail for other
+	// reasons (network, lock contention, etc.) but never because of
+	// the version string.
+	if err != nil && strings.Contains(err.Error(), "development build") {
+		t.Fatal("RunUpdate should not reject dev builds")
 	}
 }