In order to reduce the amount of data I have to test with my unit tests, I want to transition away from passing full units around. Unit maps are too big and cumbersome and they make reading the tests hard (particularly spotting the specific changes that should be happening).
This is most painful with attacks, where my current data structure passes around 2 complete copies of each unit for every attack. A reasonably formatted version of this involves nearly 2000 lines of code in my testing code.
The approach I want to go with here is an update-unit method that gets called as an event. This function would take
data that looks approximately like this:
{:unit-id "Wolfhound WLF-2 #2"
:changes {:unit/armor {:toughness/current 1 :toughness/maximum 4 :toughness/unapplied 1}}
:unit/structure {:toughness/current 4 :toughness/maximum 4 :toughness/unapplied 2}
:unit/crits {:crits/applied [] :crits/unapplied [:crit/engine]}}Then, update-unit simply calls (update-in game-state [:units unit-id] merge changes)
We can add an update-units method which loops through multiple units and applies update-unit to it.
NOTE: The above will not work! becuase of how merge works. Instead, I will look into a vec of vecs that looks more like this:
[[["Wolfhound WLF-2 #2" :unit/armor :toughness/unapplied] 1]
[["Wolfhound WLF-2 #2" :unit/structure :toughness/unapplied] 2]
[["Wolfhound WLF-2 #2" :unit/crits :crits/unapplied] [:crit/engine]]
[["Wolfhound WLF-2" :unit/acted?] true]
[["Wolfhound WLF-2" :unit/attacked?] true]]Update unit then maps over the outer vector calling (assoc-in game-state [:units %1] %2).
I want to add a health bar and a heat bar to the unit displays. I need to decide where/how they go Probably damage on the right and heat to the left.
This fix didn't work for specials. Here are the lists of possible attacks I need to handle:
- Regular attacks
- Melee attacks
- Charge/DFA attacks
- Ability attacks
- Indirect attacks
- Artillery attacks
Currently, 1-4 work. But the way I have the code written, I do not have an easy way to print and roll the attacks.
First, I cannot print or roll attacks from specials, they depend on having the whole unit map. Second, I have melee and charge attacks blended together, they should be separated (using airity? Or using different methods).
I could move all attacks of any sort into an "attacks" map. Putting them in the map would make processing attacks much easier (including WEAP hits) but makes processing abilities harder. This is probably fine, though I need to plan it out before I do it.
Create an attacks map that looks like this:
{:regular {:s 3 :s* false :m 1 :m* false :l 0 :l* true},
:physical {:s 3},
:charge {:s 5 :self 2},
:dfa {:s 4 :self 3},
:ht {:s 1 :s* true :m 0 :m* false :l 0 :l* false}}Modify the unit card to list all attacks in the correct order (regular attacks, physical attacks, special attacks)
Modify the attack-dialog so that it generates confirmation choices from the attacks map (eliminating impossible options)
Edit attack-dialog so that it preserves which attack is selected.
Edit make-attack as needed
Edit take-weapons crit so it loops through all values and decrements each one once.
I will begin by separating out game-state from client-state
- Client state :: Anything used ONLY by the client (currently selected unit, layout size, etc)
- Game State :: Anything that needs to be viewed by both players (current-phase, unit stats, turn-order, etc)
Eventually, the game-state atom will be managed 100% by server inputs whereas the client-state atom will be managed
100% by CLJFX events.
Next, I will rewrite the event handler to split these two states using the suggestion here. This split will allow me to interact with and update the two independently.
To begin with, I will just have the game-server function return a new version of the game-state atom and just merge
them together.