Cursor size 128x128

[z0Kng]

I noticed that in a recent commit:
https://github.com/intel/Display-Virtualization-for-Windows-OS/blame/47de3c4ef55a1c826332955cb40f2caef9bd4789/DVServerKMD/helper.h#L86
the cursor size was increased to 128×128, which is a welcome change especially for higher resolutions and for users who scale their cursor.

However, this appears to conflict with the virtio-gpu specification, which currently enforces a 64×64 cursor size.
https://docs.oasis-open.org/virtio/virtio/v1.3/csd01/virtio-v1.3-csd01.html#x1-4040006

Because of this mismatch, the cursor appears corrupted when using stock QEMU.

I also found this commit in your Intel-distribution-of-QEMU repository which mitigates the issue:
intel/Intel-distribution-of-QEMU@fa3963d

However, I’m not sure whether a change like this would be accepted upstream in QEMU.

Are there any plans to make this compatible with upstream QEMU? For example:

• proposing a patch to QEMU,
• updating the virtio specification to allow larger cursor sizes, or
• adding a compatibility fallback for 64×64 cursors?

I’d be interested to hear what the intended long-term approach is.

[downor]

intel/Intel-distribution-of-QEMU@fa3963d

This is a code change to make it work with various cursor size on windows VM as you see. We don't have any plan to upstream it for now.

[z0Kng]

Thanks for the answer.

I also noticed another issue: the resolution of the client (in our case, Spice/Remoteviewer, but probably also the gtk) does not get applied into the VM, for example, if the client gets resized.

The issue seems to be that

Display-Virtualization-for-Windows-OS/DVServerUMD/DVServer/DVServeredid.cpp

Line 107 in 47de3c4

monitor->ulPreferredModeIdx = 0;

is hardcoded to 0 but

Display-Virtualization-for-Windows-OS/EDIDParser/edidparser.c

Line 47 in 47de3c4

get_detailed_timing_descriptor_modes(edid_data, kmd_modelist);

does not get parsed first.
Moving the detailed timings beeing parsed first, solves the problem temporarily until to many resizes happen, and the windows registry gets to full of different monitors (due to the hotplug and a new edid every time) and windows no longer applies the preferred resolution.

Is this a know isssue? Are the plans to fix it or can/should we do a pr?