Centralize extension manager request and metadata handling

Co-authored-by: Shri Sukhani <[email protected]>

Author: cursoragent

CONTRIBUTING.md

@@ -101,6 +101,9 @@ This runs lint, format checks, compile checks, tests, and package build.
   - `tests/test_examples_naming_convention.py` (example sync/async prefix naming enforcement),
   - `tests/test_examples_syntax.py` (example script syntax guardrail),
   - `tests/test_extension_create_helper_usage.py` (extension create-input normalization helper usage enforcement),
+  - `tests/test_extension_operation_metadata_usage.py` (extension manager operation-metadata usage enforcement),
+  - `tests/test_extension_request_helper_usage.py` (extension manager request-helper usage enforcement),
+  - `tests/test_extension_route_constants_usage.py` (extension manager route-constant usage enforcement),
   - `tests/test_extract_payload_helper_usage.py` (extract start-payload helper usage enforcement),
   - `tests/test_guardrail_ast_utils.py` (shared AST guard utility contract),
   - `tests/test_job_fetch_helper_boundary.py` (centralization boundary enforcement for retry/paginated-fetch helper primitives),

hyperbrowser/client/managers/async_manager/extension.py

@@ -2,12 +2,23 @@
 
 from ...file_utils import open_binary_file
 from ..extension_create_utils import normalize_extension_create_input
-from ..extension_utils import parse_extension_list_response_data
-from ..response_utils import parse_response_model
+from ..extension_operation_metadata import EXTENSION_OPERATION_METADATA
+from ..extension_request_utils import (
+    create_extension_resource_async,
+    list_extension_resources_async,
+)
+from ..extension_route_constants import (
+    EXTENSION_CREATE_ROUTE_PATH,
+    EXTENSION_LIST_ROUTE_PATH,
+)
 from hyperbrowser.models.extension import CreateExtensionParams, ExtensionResponse
 
 
 class ExtensionManager:
+    _OPERATION_METADATA = EXTENSION_OPERATION_METADATA
+    _CREATE_ROUTE_PATH = EXTENSION_CREATE_ROUTE_PATH
+    _LIST_ROUTE_PATH = EXTENSION_LIST_ROUTE_PATH
+
     def __init__(self, client):
         self._client = client
 
@@ -18,19 +29,17 @@ async def create(self, params: CreateExtensionParams) -> ExtensionResponse:
             file_path,
             open_error_message=f"Failed to open extension file at path: {file_path}",
         ) as extension_file:
-            response = await self._client.transport.post(
-                self._client._build_url("/extensions/add"),
-                data=payload,
-                files={"file": extension_file},
+            return await create_extension_resource_async(
+                client=self._client,
+                route_path=self._CREATE_ROUTE_PATH,
+                payload=payload,
+                file_stream=extension_file,
+                model=ExtensionResponse,
+                operation_name=self._OPERATION_METADATA.create_operation_name,
             )
-        return parse_response_model(
-            response.data,
-            model=ExtensionResponse,
-            operation_name="create extension",
-        )
 
     async def list(self) -> List[ExtensionResponse]:
-        response = await self._client.transport.get(
-            self._client._build_url("/extensions/list"),
+        return await list_extension_resources_async(
+            client=self._client,
+            route_path=self._LIST_ROUTE_PATH,
         )
-        return parse_extension_list_response_data(response.data)

hyperbrowser/client/managers/extension_operation_metadata.py

@@ -0,0 +1,11 @@
+from dataclasses import dataclass
+
+
+@dataclass(frozen=True)
+class ExtensionOperationMetadata:
+    create_operation_name: str
+
+
+EXTENSION_OPERATION_METADATA = ExtensionOperationMetadata(
+    create_operation_name="create extension",
+)

hyperbrowser/client/managers/extension_request_utils.py

@@ -0,0 +1,71 @@
+from typing import Any, IO, List, Type, TypeVar
+
+from .extension_utils import parse_extension_list_response_data
+from .response_utils import parse_response_model
+from hyperbrowser.models.extension import ExtensionResponse
+
+T = TypeVar("T")
+
+
+def create_extension_resource(
+    *,
+    client: Any,
+    route_path: str,
+    payload: Any,
+    file_stream: IO,
+    model: Type[T],
+    operation_name: str,
+) -> T:
+    response = client.transport.post(
+        client._build_url(route_path),
+        data=payload,
+        files={"file": file_stream},
+    )
+    return parse_response_model(
+        response.data,
+        model=model,
+        operation_name=operation_name,
+    )
+
+
+def list_extension_resources(
+    *,
+    client: Any,
+    route_path: str,
+) -> List[ExtensionResponse]:
+    response = client.transport.get(
+        client._build_url(route_path),
+    )
+    return parse_extension_list_response_data(response.data)
+
+
+async def create_extension_resource_async(
+    *,
+    client: Any,
+    route_path: str,
+    payload: Any,
+    file_stream: IO,
+    model: Type[T],
+    operation_name: str,
+) -> T:
+    response = await client.transport.post(
+        client._build_url(route_path),
+        data=payload,
+        files={"file": file_stream},
+    )
+    return parse_response_model(
+        response.data,
+        model=model,
+        operation_name=operation_name,
+    )
+
+
+async def list_extension_resources_async(
+    *,
+    client: Any,
+    route_path: str,
+) -> List[ExtensionResponse]:
+    response = await client.transport.get(
+        client._build_url(route_path),
+    )
+    return parse_extension_list_response_data(response.data)

hyperbrowser/client/managers/extension_route_constants.py

@@ -0,0 +1,2 @@
+EXTENSION_CREATE_ROUTE_PATH = "/extensions/add"
+EXTENSION_LIST_ROUTE_PATH = "/extensions/list"

hyperbrowser/client/managers/sync_manager/extension.py

@@ -2,12 +2,23 @@
 
 from ...file_utils import open_binary_file
 from ..extension_create_utils import normalize_extension_create_input
-from ..extension_utils import parse_extension_list_response_data
-from ..response_utils import parse_response_model
+from ..extension_operation_metadata import EXTENSION_OPERATION_METADATA
+from ..extension_request_utils import (
+    create_extension_resource,
+    list_extension_resources,
+)
+from ..extension_route_constants import (
+    EXTENSION_CREATE_ROUTE_PATH,
+    EXTENSION_LIST_ROUTE_PATH,
+)
 from hyperbrowser.models.extension import CreateExtensionParams, ExtensionResponse
 
 
 class ExtensionManager:
+    _OPERATION_METADATA = EXTENSION_OPERATION_METADATA
+    _CREATE_ROUTE_PATH = EXTENSION_CREATE_ROUTE_PATH
+    _LIST_ROUTE_PATH = EXTENSION_LIST_ROUTE_PATH
+
     def __init__(self, client):
         self._client = client
 
@@ -18,19 +29,17 @@ def create(self, params: CreateExtensionParams) -> ExtensionResponse:
             file_path,
             open_error_message=f"Failed to open extension file at path: {file_path}",
         ) as extension_file:
-            response = self._client.transport.post(
-                self._client._build_url("/extensions/add"),
-                data=payload,
-                files={"file": extension_file},
+            return create_extension_resource(
+                client=self._client,
+                route_path=self._CREATE_ROUTE_PATH,
+                payload=payload,
+                file_stream=extension_file,
+                model=ExtensionResponse,
+                operation_name=self._OPERATION_METADATA.create_operation_name,
             )
-        return parse_response_model(
-            response.data,
-            model=ExtensionResponse,
-            operation_name="create extension",
-        )
 
     def list(self) -> List[ExtensionResponse]:
-        response = self._client.transport.get(
-            self._client._build_url("/extensions/list"),
+        return list_extension_resources(
+            client=self._client,
+            route_path=self._LIST_ROUTE_PATH,
         )
-        return parse_extension_list_response_data(response.data)

tests/test_architecture_marker_usage.py

@@ -47,6 +47,9 @@
     "tests/test_extension_create_helper_usage.py",
     "tests/test_extract_payload_helper_usage.py",
     "tests/test_examples_naming_convention.py",
+    "tests/test_extension_operation_metadata_usage.py",
+    "tests/test_extension_request_helper_usage.py",
+    "tests/test_extension_route_constants_usage.py",
     "tests/test_job_pagination_helper_usage.py",
     "tests/test_job_fetch_helper_boundary.py",
     "tests/test_job_fetch_helper_usage.py",

tests/test_core_type_helper_usage.py

@@ -37,6 +37,9 @@
     "hyperbrowser/client/managers/computer_action_utils.py",
     "hyperbrowser/client/managers/computer_action_payload_utils.py",
     "hyperbrowser/client/managers/extension_create_utils.py",
+    "hyperbrowser/client/managers/extension_operation_metadata.py",
+    "hyperbrowser/client/managers/extension_request_utils.py",
+    "hyperbrowser/client/managers/extension_route_constants.py",
     "hyperbrowser/client/managers/extract_payload_utils.py",
     "hyperbrowser/client/managers/job_fetch_utils.py",
     "hyperbrowser/client/managers/job_operation_metadata.py",

tests/test_extension_operation_metadata.py

@@ -0,0 +1,7 @@
+from hyperbrowser.client.managers.extension_operation_metadata import (
+    EXTENSION_OPERATION_METADATA,
+)
+
+
+def test_extension_operation_metadata_values():
+    assert EXTENSION_OPERATION_METADATA.create_operation_name == "create extension"

tests/test_extension_operation_metadata_usage.py

@@ -0,0 +1,20 @@
+from pathlib import Path
+
+import pytest
+
+pytestmark = pytest.mark.architecture
+
+
+MODULES = (
+    "hyperbrowser/client/managers/sync_manager/extension.py",
+    "hyperbrowser/client/managers/async_manager/extension.py",
+)
+
+
+def test_extension_managers_use_shared_operation_metadata():
+    for module_path in MODULES:
+        module_text = Path(module_path).read_text(encoding="utf-8")
+        assert "extension_operation_metadata import" in module_text
+        assert "_OPERATION_METADATA = " in module_text
+        assert "operation_name=self._OPERATION_METADATA." in module_text
+        assert 'operation_name="' not in module_text