Skip to content

DBX-6889 Sticky note color#915

Merged
huydo862003 merged 19 commits into
masterfrom
feat/sticky-note-color
Jun 4, 2026
Merged

DBX-6889 Sticky note color#915
huydo862003 merged 19 commits into
masterfrom
feat/sticky-note-color

Conversation

@huydo862003

@huydo862003 huydo862003 commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Support sticky note color:
    Note "..." [color: none|#FFFFFF]{}
    
  • Support none color beside hex in Sticky note.
  • Fix a bug where sticky note with double quotes throw a runtime error
  • Fix a bug where sticky note isn't suggested at top-level

Issue

(issue link here)

Lasting Changes (Technical)

(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)

  • (Added class EmailValidator to validate email address' validity)
  • (Added Tenant#is_trial? check)

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Lint Checks Passed
  • Unit Tests Passed
  • Coverage Tests Passed
  • Integration Tests Passed
  • Code Review

@huydo862003 huydo862003 force-pushed the feat/sticky-note-color branch from 0f78999 to 775a600 Compare June 2, 2026 04:27
@huydo862003 huydo862003 force-pushed the feat/sticky-note-color branch from 775a600 to efc9f7c Compare June 2, 2026 04:30
@huydo862003 huydo862003 changed the title Sticky note color DBX-6889 Sticky note color Jun 4, 2026
@linear-code

linear-code Bot commented Jun 4, 2026

Copy link
Copy Markdown

DBX-6889

Comment thread packages/dbml-parse/src/core/global_modules/note/interpret.ts
Comment thread packages/dbml-parse/src/core/local_modules/note/validate.ts Outdated
Comment thread packages/dbml-parse/src/core/utils/interpret.ts Outdated
@huydo862003 huydo862003 force-pushed the feat/sticky-note-color branch from bd1eaf0 to 7e14a3a Compare June 4, 2026 09:55
@huydo862003 huydo862003 force-pushed the feat/sticky-note-color branch from 413d796 to 73663c1 Compare June 4, 2026 10:03
@huydo862003 huydo862003 force-pushed the feat/sticky-note-color branch from 73663c1 to 22833d9 Compare June 4, 2026 10:05
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

Coverage Report

Commit: 4481487

Overall Coverage

Metric Coverage
Lines ✅ 85.04% (8567/10074)
Statements ✅ 82.42% (9305/11290)
Functions ✅ 87.40% (1797/2056)
Branches ⚠️ 73.57% (5572/7574)

Package Coverage

Package Lines Statements Functions Branches
@dbml/dbml-cli ✅ 100.00% ✅ 100.00% ✅ 100.00% ✅ 100.00%
@dbml/dbml-connector ⚠️ 64.62% ⚠️ 64.36% ⚠️ 59.53% ⚠️ 59.09%
@dbml/dbml-core N/A N/A N/A N/A
@dbml/dbml-parse ✅ 87.15% ✅ 84.19% ✅ 89.95% ⚠️ 74.66%

⚠️ Coverage Warnings

The following packages have coverage below 80%:

  • @dbml/dbml-connector: 64.62% line coverage

Files with Coverage Below 80%

@dbml/dbml-connector

9 file(s) below 80% coverage
File Lines Statements Functions Branches
src/connectors/bigquery/index.ts 0.00% 0.00% 0.00% 0.00%
src/utils/credential-loader.ts 0.00% 0.00% 0.00% 0.00%
src/utils/helpers.ts 0.00% 0.00% 0.00% 0.00%
src/connectors/snowflake/index.ts 10.56% 10.31% 0.00% 0.00%
src/utils/parseSchema.ts 46.15% 42.85% 28.57% 27.27%
src/connectors/connector.ts 66.66% 66.66% 100.00% 57.14%
src/connectors/oracle/tables.ts 71.25% 67.39% 100.00% 56.96%
src/connectors/oracle/index.ts 80.00% 80.76% 100.00% 25.00%
src/connectors/oracle/utils.ts 85.71% 85.71% 100.00% 71.42%

@dbml/dbml-parse

79 file(s) below 80% coverage
File Lines Statements Functions Branches
src/compiler/queries/container/scope.ts 0.00% 0.00% 0.00% 0.00%
src/services/diagnostics/provider.ts 0.00% 0.00% 0.00% 0.00%
src/compiler/queries/pipeline/interpret.ts 11.76% 13.51% 66.66% 41.66%
src/services/suggestions/crossFile.ts 19.35% 19.44% 33.33% 10.00%
src/core/local_modules/enum/index.ts 48.00% 46.29% 57.14% 52.63%
src/core/global_modules/project/interpret.ts 52.50% 46.66% 83.33% 23.07%
src/compiler/projectLayout/layout.ts 54.16% 53.84% 75.00% 52.63%
src/core/global_modules/enum/bind.ts 60.00% 62.50% 83.33% 37.50%
src/compiler/queries/legacy/parse.ts 61.53% 53.33% 66.66% 25.00%
src/core/local_modules/ref/index.ts 62.50% 61.76% 100.00% 57.14%
src/core/types/symbol/symbols.ts 62.54% 54.71% 59.83% 45.07%
src/core/global_modules/records/utils/data/values.ts 63.30% 55.71% 72.72% 49.28%
src/core/local_modules/tableGroup/validate.ts 64.10% 64.44% 71.42% 58.00%
src/compiler/queries/legacy/token.ts 66.66% 66.66% 66.66% 100.00%
src/core/local_modules/program/index.ts 66.66% 69.23% 75.00% 62.50%
src/core/global_modules/note/bind.ts 69.23% 71.42% 83.33% 50.00%
src/core/local_modules/checks/index.ts 69.23% 75.00% 100.00% 64.28%
src/core/types/report.ts 70.83% 66.66% 83.33% 71.42%
src/core/local_modules/tablePartial/validate.ts 73.01% 71.83% 79.22% 57.67%
src/core/local_modules/project/index.ts 73.07% 73.07% 100.00% 68.18%
src/compiler/queries/utils.ts 73.10% 73.38% 90.90% 51.11%
src/core/global_modules/project/bind.ts 73.33% 75.00% 100.00% 50.00%
src/core/local_modules/indexes/index.ts 73.68% 69.35% 63.63% 64.28%
src/core/local_modules/indexes/validate.ts 73.91% 74.66% 90.90% 56.00%
src/core/local_modules/use/index.ts 73.91% 75.00% 75.00% 81.25%
src/core/local_modules/note/index.ts 75.00% 75.86% 75.00% 72.72%
src/core/local_modules/project/validate.ts 75.00% 75.86% 100.00% 56.25%
src/services/suggestions/utils/index.ts 75.00% 75.00% 100.00% 60.71%
src/core/local_modules/records/index.ts 75.60% 76.19% 100.00% 68.08%
src/core/global_modules/indexes/bind.ts 75.67% 74.35% 90.90% 68.96%
src/core/local_modules/custom/index.ts 76.47% 76.19% 80.00% 75.00%
src/core/global_modules/records/utils/data/sqlTypes.ts 76.59% 80.64% 82.35% 72.22%
src/core/global_modules/utils.ts 76.92% 73.80% 62.50% 62.50%
src/core/local_modules/note/validate.ts 77.55% 76.36% 83.33% 71.05%
src/core/global_modules/tablePartial/interpret.ts 77.65% 70.64% 78.94% 53.73%
src/core/global_modules/tableGroup/bind.ts 79.31% 80.00% 100.00% 57.14%
src/core/types/filepath.ts 79.48% 78.57% 77.77% 70.37%
src/core/global_modules/program/utils.ts 80.00% 80.00% 100.00% 70.00%
src/core/local_modules/records/validate.ts 80.00% 80.55% 93.75% 72.30%
src/core/local_modules/checks/validate.ts 81.25% 82.69% 93.75% 70.00%
src/core/local_modules/diagramView/validate.ts 81.33% 78.04% 84.21% 72.72%
src/core/global_modules/indexes/interpret.ts 81.39% 72.00% 100.00% 56.66%
src/core/local_modules/tablePartial/index.ts 81.48% 81.48% 100.00% 77.27%
src/core/local_modules/enum/validate.ts 81.96% 78.78% 81.25% 71.05%
__tests__/utils/compiler.ts 82.14% 80.10% 100.00% 57.26%
src/core/global_modules/records/bind.ts 82.92% 83.72% 93.75% 67.30%
src/compiler/queries/container/token.ts 83.33% 85.71% 100.00% 75.00%
src/core/global_modules/ref/bind.ts 83.33% 83.87% 90.00% 75.00%
src/core/parser/parser.ts 84.36% 84.59% 100.00% 75.80%
src/core/global_modules/records/utils/constraints/pk.ts 84.61% 81.42% 92.59% 56.52%
src/core/local_modules/table/validate.ts 85.23% 85.80% 90.24% 75.17%
__tests__/utils/mocks.ts 85.71% 86.20% 75.00% 100.00%
src/core/global_modules/use/index.ts 86.31% 82.92% 100.00% 78.22%
src/services/suggestions/provider.ts 86.56% 82.71% 96.82% 75.15%
src/core/global_modules/tablePartial/bind.ts 86.79% 87.27% 100.00% 71.42%
src/services/suggestions/utils/useMerger.ts 86.95% 81.13% 100.00% 46.34%
src/core/global_modules/tableGroup/interpret.ts 88.09% 88.37% 100.00% 77.27%
src/services/suggestions/recordRowSnippet.ts 88.46% 87.09% 100.00% 73.80%
src/compiler/queries/nodeAtPosition.ts 88.88% 90.00% 100.00% 75.00%
src/core/global_modules/diagramView/index.ts 89.16% 86.23% 83.33% 78.18%
src/compiler/index.ts 89.74% 89.91% 75.00% 75.00%
src/core/global_modules/table/interpret.ts 90.62% 84.72% 95.45% 67.70%
src/core/global_modules/records/index.ts 90.90% 87.15% 100.00% 79.16%
src/core/global_modules/schema/index.ts 92.26% 82.46% 91.66% 70.07%
src/core/types/symbol/metadata.ts 92.34% 78.24% 97.61% 63.15%
src/core/utils/interpret.ts 93.33% 90.00% 100.00% 73.23%
src/core/global_modules/diagramView/interpret.ts 94.54% 90.40% 92.85% 75.75%
src/services/suggestions/use.ts 94.68% 87.61% 100.00% 77.45%
src/core/global_modules/note/interpret.ts 95.45% 95.65% 100.00% 75.00%
src/core/global_modules/records/interpret.ts 95.97% 92.59% 100.00% 79.54%
__tests__/examples/interpreter/multifile/utils.ts 96.00% 89.65% 100.00% 62.50%
src/compiler/queries/canonicalName.ts 96.96% 92.10% 100.00% 76.66%
src/core/global_modules/program/interpret.ts 97.07% 91.45% 100.00% 70.31%
src/core/types/errors.ts 98.48% 98.49% 66.66% 100.00%
src/compiler/queries/transform/renameTable.ts 99.05% 90.47% 100.00% 78.82%
src/core/global_modules/checks/interpret.ts 100.00% 88.88% 100.00% 60.00%
src/core/global_modules/program/index.ts 100.00% 85.71% 100.00% 75.00%
src/core/global_modules/records/utils/constraints/unique.ts 100.00% 95.00% 100.00% 62.50%
src/services/definition/provider.ts 100.00% 95.23% 100.00% 71.42%

@huydo862003 huydo862003 merged commit cfe90b0 into master Jun 4, 2026
6 checks passed
@huydo862003 huydo862003 deleted the feat/sticky-note-color branch June 4, 2026 10:27
@huydo862003 huydo862003 restored the feat/sticky-note-color branch June 5, 2026 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants