Null pointer causing crash in debug builds.

[Makogan]

I suspect there is a bug in the library. In particular at line:

spirv-reflect-rs/src/convert.rs

Line 66 in b2c4527

let ffi_members =

It seems like it is possible for ffi_type.members to be null if ffi_type.member_count is 0. However, rust considers this unsafe and will return the error:

unsafe precondition(s) violated: slice::from_raw_parts requires the pointer to be aligned and non-null, and the total size of the slice not to exceed `isize::MAX`

Thus no application using this crate can run correctly in debug mode.

OS: ubuntu 22.04
crate version: 0.2.3
rustc version: rustc 1.78.0-nightly (ef324565d 2024-02-27)

[Makogan]

I pushed a PR that addresses the issue. It's just a matter of explicitly checking for null pointers. In the process I also noticed that the rust crate points to a rather old commit of the C repo.

[Detrixukaon58]

Has there been any update on this bug? It is still appearing in the current crate, so I am assuming that it has not been addressed yet.

[speedy-lex]

Still happening to me and I'm not sure if @gwihlidal is active so it might be a while before he accepts the PR.

[speedy-lex]

As a temporary fix you can replace
spirv-reflect = " . . . "
with
spirv-reflect = { git = "https://github.com/gfxstrand/spirv-reflect-rs.git" }
in your Cargo.toml

[speedy-lex]

PR #27 has been closed and therefore this issue is resolved