refactor: decouple output_to_file from gemini_debug

Check output_to_file first, independently of debug mode. The debug flag
only controls whether --debug is passed to gemini CLI. Also extract
command args to avoid duplicating the gemini invocation.

Ref: #479

Author: michalszelagsonos

action.yml

@@ -311,24 +311,30 @@ runs:
         # Keep track of whether we've failed
         FAILED=false
 
+        # Build the base command arguments
+        GEMINI_ARGS="--yolo --prompt ${PROMPT} --output-format json"
+        if [[ "${GEMINI_DEBUG}" = true ]]; then
+          GEMINI_ARGS="--debug ${GEMINI_ARGS}"
+        fi
+
         # Run Gemini CLI with the provided prompt, using JSON output format
         # We capture stdout (JSON) to TEMP_STDOUT and stderr to TEMP_STDERR
-        if [[ "${GEMINI_DEBUG}" = true ]] && [[ "${OUTPUT_TO_FILE}" = true ]]; then
-          echo "::notice::Gemini CLI debug output redirected to files (gemini-artifacts/)"
-          if ! gemini --debug --yolo --prompt "${PROMPT}" --output-format json 2> "${TEMP_STDERR}" 1> "${TEMP_STDOUT}"; then
+        if [[ "${OUTPUT_TO_FILE}" = true ]]; then
+          echo "::notice::Gemini CLI output redirected to files (gemini-artifacts/)"
+          if ! gemini ${GEMINI_ARGS} 2> "${TEMP_STDERR}" 1> "${TEMP_STDOUT}"; then
             FAILED=true
           fi
         elif [[ "${GEMINI_DEBUG}" = true ]]; then
           echo "::warning::Gemini CLI debug logging is enabled. This will stream responses, which could reveal sensitive information if processed with untrusted inputs."
           echo "::: Start Gemini CLI STDOUT :::"
-          if ! gemini --debug --yolo --prompt "${PROMPT}" --output-format json 2> >(tee "${TEMP_STDERR}" >&2) | tee "${TEMP_STDOUT}"; then
+          if ! gemini ${GEMINI_ARGS} 2> >(tee "${TEMP_STDERR}" >&2) | tee "${TEMP_STDOUT}"; then
             FAILED=true
           fi
           # Wait for async stderr logging to complete. This is because process substitution in Bash is async so let tee finish writing to ${TEMP_STDERR}
           sleep 1
           echo "::: End Gemini CLI STDOUT :::"
         else
-          if ! gemini --yolo --prompt "${PROMPT}" --output-format json 2> "${TEMP_STDERR}" 1> "${TEMP_STDOUT}"; then
+          if ! gemini ${GEMINI_ARGS} 2> "${TEMP_STDERR}" 1> "${TEMP_STDOUT}"; then
             FAILED=true
           fi
         fi