discarding line or file changes on a network volume does not work

[il-demone-guardiano]

in GitUp version 1.5.0,
using the "Discard Line Changes…", "Discard File Changes" or using the "Discard All…" button causes the error message

“filename” couldn’t be moved to the trash because the volume “volumename” doesn’t have one.

in GitUp version 1.4.3 "Discard File Changes" and "Discard All…" work correctly, but "Discard Line Changes…" fails with the error message "Undefined error: 0"

[lucasderraugh]

I think I may know why this happens, curious what the file path is on your repo (is it on an external drive?)

[il-demone-guardiano]

I think I may know why this happens, curious what the file path is on your repo (is it on an external drive?)

the repo is on a network share, the path is in the form "/Volumes/ShareName/RepoName", but the actual path does not make any difference (it happens if the repo is deep inside the volume or in the root).

the behaviour is the same on an nfs share (linux) and on a smb share (windows).

the volumes, being "generic" network shares do not, indeed have a trashcan: if you try to trash an item from the finder a "This item will be deleted immediately. You can’t undo this action." message appears.

[lucasderraugh]

All good, I'm sure it's fallout from this change: #2781

[il-demone-guardiano]

All good, I'm sure it's fallout from this change: #2781

as far as "Discard Line Changes…" goes, i don't recall it ever working if the repo is on was network share. always "Undefined error: 0"

[lucasderraugh]

@il-demone-guardiano Interesting, ya I'll have to figure out how to easily test a networked drive. For 1.5.0 ideally we'd like to not introduce any regressions from 1.4.3. I'll probably just revert that above change and then rollout to the stable channel next week.

[il-demone-guardiano]

@il-demone-guardiano Interesting, ya I'll have to figure out how to easily test a networked drive. For 1.5.0 ideally we'd like to not introduce any regressions from 1.4.3. I'll probably just revert that above change and then rollout to the stable channel next week.

there's a relatively simple way:

edit /etc/exports

and add the following line:

/Users/_your_username_/share -mapall=_your_username_ -network 127.0.0.0 -mask 255.255.255.0 -alldirs

the run

sudo nfsd disable; sudo nfsd enable

at this point showmount -e

should report:

Exports list on localhost: /Users/_your_username_/share loopback

from the finder with ⌘K you should be able to mount nfs://localhost/Users/_your_username_/share. this works on my setup and reproduces both the issues.

[lucasderraugh]

@il-demone-guardiano Thanks for the help! I'll test it out tonight and make the appropriate changes.

[lucasderraugh]

Should be resolved with 99757de