Skip to content

Fix verification 'never complete' and offer_next routing on gaps_found #57

Description

@LeVarez

Parent: #54

Problem 1: Verification says "never complete"

The verifier (step 7) runs on the phase branch, but if the per-plan merge loop didn't complete (see #55), the phase branch has NO executor work. The verifier checks file existence and wiring on an empty phase branch → reports gaps_found / "never complete".

This is a downstream consequence of the merge loop bug (#55). Once merges are fixed, the verifier will see the work. However, we should also add a safety check.

Problem 2: No next steps guidance on gaps_found

When step 7 returns gaps_found, the instructions present gaps but don't clearly define whether steps 8-11 execute. The user sees the gaps message but may not see structured offer_next routing with clear commands.

Changes (execute-phase.md)

2F. Explicit early-exit routing after step 7

Add conditional block after verification:

If verification status is NOT "passed":
  - Push current state to origin (step 10.5 logic)
  - Jump to step 11 offer_next with the appropriate route
  - Do NOT execute steps 8-10.6 (GitHub sync, handoff, completion commit, doc-updater)
  • gaps_found → Skip to step 10.5 (push) + step 11 (offer_next Route C)
  • human_needed → Skip to checklist, wait for input
  • passed → Continue to step 8 as normal

Files

  • .claude/commands/vit/execute-phase.md (zone 2F)
  • .claude/vit/workflows/execute-phase.md (verify_phase_goal step)

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions