Skip to content

Commit 20d0cd8

Browse files
ouzkilicclaude
andcommitted
chore(deps): update @google-cloud/firestore to ^8.0.0 to resolve @tootallnate/once vulnerability
Replace internal import of DEFAULT_DATABASE_ID from @google-cloud/firestore/build/src/path with a local constant, as v8 no longer ships .d.ts for that internal module. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
1 parent a3faacf commit 20d0cd8

5 files changed

Lines changed: 129 additions & 90 deletions

File tree

package-lock.json

Lines changed: 125 additions & 86 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@
218218
"uuid": "^11.0.2"
219219
},
220220
"optionalDependencies": {
221-
"@google-cloud/firestore": "^7.11.0",
221+
"@google-cloud/firestore": "^8.0.0",
222222
"@google-cloud/storage": "^7.19.0"
223223
},
224224
"devDependencies": {

src/firestore/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import { Firestore } from '@google-cloud/firestore';
2424
import { App, getApp } from '../app';
2525
import { FirebaseApp } from '../app/firebase-app';
2626
import { FirestoreService, FirestoreSettings } from './firestore-internal';
27-
import { DEFAULT_DATABASE_ID } from '@google-cloud/firestore/build/src/path';
27+
const DEFAULT_DATABASE_ID = '(default)';
2828

2929
export {
3030
AddPrefixToKeys,

test/unit/firestore/firestore.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ import {
2828
} from '../../../src/app/credential-internal';
2929
import { FirestoreService, getFirestoreOptions } from '../../../src/firestore/firestore-internal';
3030
import { getSdkVersion } from '../../../src/utils/index';
31-
import { DEFAULT_DATABASE_ID } from '@google-cloud/firestore/build/src/path';
31+
const DEFAULT_DATABASE_ID = '(default)';
3232

3333
describe('Firestore', () => {
3434
let mockApp: FirebaseApp;

test/unit/firestore/index.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import * as chaiAsPromised from 'chai-as-promised';
2424
import * as mocks from '../../resources/mocks';
2525
import { App } from '../../../src/app/index';
2626
import { getFirestore, initializeFirestore, Firestore } from '../../../src/firestore/index';
27-
import { DEFAULT_DATABASE_ID } from '@google-cloud/firestore/build/src/path';
27+
const DEFAULT_DATABASE_ID = '(default)';
2828

2929
chai.should();
3030
chai.use(sinonChai);

0 commit comments

Comments
 (0)