Skip to content

[Suggestion/Correction] Lesson 6: Random forests - notebook correction needed for last code cell #129

Description

@ishraq10199

In the following notebook, there is a possible mistake in a code cell:

07-how-random-forests-really-work.ipynb

The code cell in question:

pd.DataFrame(dict(cols=trn_xs.columns, imp=m.feature_importances_)).plot('cols', 'imp', 'barh');

The description around the cell denotes that this should plot the feature_importances_ of the RandomForestClassifier, but m is the DecisionTreeClassifier initialized in one of the code cells above, like so:

m = DecisionTreeClassifier(max_leaf_nodes=4).fit(trn_xs, trn_y);

It is my understanding that the code cell needs to be the following:

pd.DataFrame(dict(cols=trn_xs.columns, imp=rf.feature_importances_)).plot('cols', 'imp', 'barh');

Context for rf:

rf = RandomForestClassifier(100, min_samples_leaf=5)

I would be happy to open a PR, once someone acknowledges that this is in fact a valid correction. Thanks! 🤗

Below is a screenshot to show that they indeed plot different things

Image

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions