Recently, we introduced a CI pipeline for the lts branch (see #1302). However, it appears that the CI is currently failing due to issues with [email protected] on both Node.js 8.x and Node.js 6.x.
> [email protected] test /home/runner/work/multer/multer
> mocha --reporter spec --exit --check-leaks test/
/home/runner/work/multer/multer/node_modules/busboy/lib/utils.js:469
} catch {}
^
SyntaxError: Unexpected token {
As noted, [email protected] has a minimum Node.js support of >=10.16 (reference). Based on this, it seems that support for Node.js 6.x and 8.x has effectively been dropped. However, our engines field is still defined as "node": ">= 6.0.0" (reference).
Given this, I would like to propose updating the engines field to accurately reflect the new minimum supported Node.js version. Since this dependency update was introduced as part of a security patch (reference1, reference2), I believe it is reasonable to formally drop support for older Node.js versions (as has effectively already occurred), and treat this as a minor or patch-level semver update.
As this change may be considered an exception to our current ADR policy (see here), I would like to request feedback and guidance from the @expressjs/express-tc team on how best to proceed.
Recently, we introduced a CI pipeline for the
ltsbranch (see #1302). However, it appears that the CI is currently failing due to issues with[email protected]on both Node.js 8.x and Node.js 6.x.As noted,
[email protected]has a minimum Node.js support of>=10.16(reference). Based on this, it seems that support for Node.js 6.x and 8.x has effectively been dropped. However, ourenginesfield is still defined as"node": ">= 6.0.0"(reference).Given this, I would like to propose updating the
enginesfield to accurately reflect the new minimum supported Node.js version. Since this dependency update was introduced as part of a security patch (reference1, reference2), I believe it is reasonable to formally drop support for older Node.js versions (as has effectively already occurred), and treat this as a minor or patch-level semver update.As this change may be considered an exception to our current ADR policy (see here), I would like to request feedback and guidance from the @expressjs/express-tc team on how best to proceed.