Add operator to conditional links

[poautran]

In GitLab by @woutdenolf on Jan 21, 2026, 12:04 GMT+1:

See https://confluence.esrf.fr/display/AAWWK/2026-01-07+Meeting+notes#id-20260107Meetingnotes-Conditionallinks:addoperator

Migrated from GitLab: https://gitlab.esrf.fr/workflow/ewoks/ewokscore/-/issues/84

[LudoBroche]

Related issue in ewoksppf : ewoks-kit/ewoksppf#172

[LudoBroche]

@ewoks-kit/core-developers

I'm digging into analysis.py to understand the code.

Question I'm a little confuse about this function:

ewokscore/src/ewokscore/graph/analysis.py

Lines 292 to 306 in 3a5ef6f

	def node_has_noncovered_conditions(
	graph: networkx.DiGraph, source_id: NodeIdType
	) -> bool:
	conditions_else_value = graph.nodes[source_id].get("conditions_else_value", None)
	complements = {
	True: {False, conditions_else_value},
	False: {True, conditions_else_value},
	}
	condition_values = node_condition_values(graph, source_id)
	for values in condition_values.values():
	for value in values:
	cvalue = complements.get(value, conditions_else_value)
	if cvalue not in values:
	return True
	return False

If we have :

• Node "task1" attributes: {"conditions_else_value": "OTHERWISE"}
• Link1 attributes: {"conditions": [{"source_output": "is_valid", "value": True}]}
• Link2 (Fallback) attributes: {"conditions": [{"source_output": "is_valid", "value": "OTHERWISE"}]}

node_has_noncovered_conditions should return False (all conditions are covered )

First iteration of the loop :

line 295 -> conditions_else_value = "OTHERWISE"
line 296 -> complements = {True: {False, "OTHERWISE"}, False: {True, "OTHERWISE"}}
line 300 -> condition_values ={"is_valid": {True, "OTHERWISE"}}
line 301-> values = {True, "OTHERWISE"}
line 303 -> cvalue = {False, "OTHERWISE"}
line 304 -> if cvalue not in values:   ( if {False, "OTHERWISE"} not in {True, "OTHERWISE"}: ) return True

Test script:

import networkx
from ewokscore.graph.analysis import node_condition_values, node_has_noncovered_conditions

def node_has_noncovered_conditions(graph, source_id):
    conditions_else_value = graph.nodes[source_id].get('conditions_else_value', None)
    complements = {
        True: {False, conditions_else_value},
        False: {True, conditions_else_value},
    }
    condition_values = node_condition_values(graph, source_id)
    for values in condition_values.values():
        for value in values:
            cvalue = complements.get(value, conditions_else_value)
            if cvalue not in values:
                return True
    return False

graph = networkx.DiGraph()
graph.add_node('task1', conditions_else_value='OTHERWISE')
graph.add_node('task2')
graph.add_node('fallback')
graph.add_edge('task1', 'task2', conditions=[{'source_output': 'is_valid', 'value': True}])
graph.add_edge('task1', 'fallback', conditions=[{'source_output': 'is_valid', 'value': 'OTHERWISE'}])

print('condition_values:', dict(node_condition_values(graph, 'task1')))
print('result:', node_has_noncovered_conditions(graph, 'task1'))

print -> 
condition_values: {'is_valid': {True, 'OTHERWISE'}}
result: True

Is this a bug or I missunderstood the code completely ?

[LudoBroche]

Discuss with @woutdenolf, indeed it's a bug.
Need to be rework anyway for the operator.