From 45a4499f91a72fc2433298dee3d355f4a1145afa Mon Sep 17 00:00:00 2001 From: Patrick Dodgen Date: Tue, 7 Jul 2026 12:16:32 -0600 Subject: [PATCH] chore(ci): clear Node 20 deprecation warnings across shared workflows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit GitHub is forcing Node 20 actions to run on Node 24 and logs a warning on every run. Bump the actions that have Node 24 native versions and add setup-helm/setup-kubectl tokens to eliminate the noisy fallback warning about GITHUB_TOKEN not being set. Bumps aws-actions/configure-aws-credentials v4 -> v5 (helm-deploy-eks) azure/setup-helm v3 -> v4 (4x helm-* workflows) Azure/setup-kubectl v3 -> v4 (4x helm-* workflows) actions/setup-node v4 -> v5 (2x openapi-generate) mathieudutour/github-tag-action v6.1 -> v6.2 (2x build-php-*) Token wiring Add `token: ${{ github.token }}` to every azure/setup-helm and Azure/setup-kubectl invocation. Without it, both actions try to fetch the latest tool version via GitHub API, fail auth, and log a scary '::warning::[@octokit/auth-action] GITHUB_TOKEN not set' message on every deploy. Cosmetic today (deploys still succeed with a hard-coded default version) but eliminates the noise. Deferred to follow-up actions/upload-artifact@v4 -> v5 has a breaking change (duplicate name now errors instead of warns) so it needs a per- usage review before bumping. docker/setup-buildx-action@v3, docker/login-action@v3, docker/build-push-action@v6 have no Node 24 upstream release yet. Spotted (not fixed here — worth a separate ticket) helm-rollback.yaml:31 references ${{ inputs.image_tag }} in the checkout ref, but the workflow's inputs are {deployment, environment, namespace} — this fails silently by falling through to the default ref. Pre-existing; noise-only in actionlint until someone tries to use it. Refs DEVEX-1683 (this cleanup), DEVEX-1653 (RT v2 downstream), DEVEX-1680. --- .github/workflows/build-php-laravel.yaml | 4 ++-- .github/workflows/build-php-v1.yaml | 4 ++-- .github/workflows/helm-deploy-eks.yaml | 13 ++++++++++--- .github/workflows/helm-deploy.yaml | 7 +++++-- .github/workflows/helm-deployv2.yaml | 8 ++++++-- .github/workflows/helm-rollback.yaml | 8 ++++++-- .../openapi-generate-javascript-client.yaml | 2 +- .../openapi-generate-typescript-client.yaml | 2 +- 8 files changed, 33 insertions(+), 15 deletions(-) diff --git a/.github/workflows/build-php-laravel.yaml b/.github/workflows/build-php-laravel.yaml index ae8b6dc..c24f6a8 100644 --- a/.github/workflows/build-php-laravel.yaml +++ b/.github/workflows/build-php-laravel.yaml @@ -57,7 +57,7 @@ jobs: with: fetch-depth: 0 - id: dry_tag_version - uses: mathieudutour/github-tag-action@v6.1 + uses: mathieudutour/github-tag-action@v6.2 with: github_token: ${{ secrets.gh_token }} release_branches: ${{ inputs.release_branches }} @@ -94,7 +94,7 @@ jobs: with: fetch-depth: 0 - id: tag_version - uses: mathieudutour/github-tag-action@v6.1 + uses: mathieudutour/github-tag-action@v6.2 with: github_token: ${{ secrets.gh_token }} release_branches: ${{ inputs.release_branches }} diff --git a/.github/workflows/build-php-v1.yaml b/.github/workflows/build-php-v1.yaml index 7289bbc..9009574 100644 --- a/.github/workflows/build-php-v1.yaml +++ b/.github/workflows/build-php-v1.yaml @@ -56,7 +56,7 @@ jobs: with: fetch-depth: 0 - id: dry_tag_version - uses: mathieudutour/github-tag-action@v6.1 + uses: mathieudutour/github-tag-action@v6.2 with: github_token: ${{ secrets.gh_token }} release_branches: ${{ inputs.release_branches }} @@ -140,7 +140,7 @@ jobs: with: fetch-depth: 0 - id: tag_version - uses: mathieudutour/github-tag-action@v6.1 + uses: mathieudutour/github-tag-action@v6.2 with: github_token: ${{ secrets.gh_token }} release_branches: ${{ inputs.release_branches }} diff --git a/.github/workflows/helm-deploy-eks.yaml b/.github/workflows/helm-deploy-eks.yaml index 4b95a10..587a6f7 100644 --- a/.github/workflows/helm-deploy-eks.yaml +++ b/.github/workflows/helm-deploy-eks.yaml @@ -55,7 +55,7 @@ jobs: with: ref: ${{ inputs.image_tag }} - name: Configure AWS Credentials - uses: aws-actions/configure-aws-credentials@v4 + uses: aws-actions/configure-aws-credentials@v5 with: aws-access-key-id: ${{ secrets.aws_access_id }} aws-secret-access-key: ${{ secrets.aws_access_secret }} @@ -63,9 +63,16 @@ jobs: role-duration-seconds: 1200 role-session-name: GithubActions-${{ github.event.repository.name }} - name: Setup Helm - uses: azure/setup-helm@v3 + uses: azure/setup-helm@v4 + with: + # token: fetches the latest Helm release from GitHub. Without it + # the action falls back to a hardcoded default version and emits + # a warning on every deploy log. + token: ${{ github.token }} - name: Setup Kubectl - uses: Azure/setup-kubectl@v3 + uses: Azure/setup-kubectl@v4 + with: + token: ${{ github.token }} - name: deploy run: | echo "${{ secrets.kubeconfig }}" >> kube.config diff --git a/.github/workflows/helm-deploy.yaml b/.github/workflows/helm-deploy.yaml index 5482b83..bc6e36e 100644 --- a/.github/workflows/helm-deploy.yaml +++ b/.github/workflows/helm-deploy.yaml @@ -58,11 +58,14 @@ jobs: with: ref: ${{ inputs.image_tag }} - name: Setup Helm - uses: azure/setup-helm@v3 + uses: azure/setup-helm@v4 with: version: ${{ inputs.helm_version }} + token: ${{ github.token }} - name: Setup Kubectl - uses: Azure/setup-kubectl@v3 + uses: Azure/setup-kubectl@v4 + with: + token: ${{ github.token }} - name: deploy run: | kubectl config set-cluster k8s --server="${{ secrets.k8s_server }}" diff --git a/.github/workflows/helm-deployv2.yaml b/.github/workflows/helm-deployv2.yaml index f6ee6b5..a1712ab 100644 --- a/.github/workflows/helm-deployv2.yaml +++ b/.github/workflows/helm-deployv2.yaml @@ -51,9 +51,13 @@ jobs: with: ref: ${{ inputs.image_tag }} - name: Setup Helm - uses: azure/setup-helm@v3 + uses: azure/setup-helm@v4 + with: + token: ${{ github.token }} - name: Setup Kubectl - uses: Azure/setup-kubectl@v3 + uses: Azure/setup-kubectl@v4 + with: + token: ${{ github.token }} - name: deploy run: | echo "${{ secrets.kubeconfig }}" >> kube.config diff --git a/.github/workflows/helm-rollback.yaml b/.github/workflows/helm-rollback.yaml index a9b17d8..e9530fc 100644 --- a/.github/workflows/helm-rollback.yaml +++ b/.github/workflows/helm-rollback.yaml @@ -30,9 +30,13 @@ jobs: with: ref: ${{ inputs.image_tag }} - name: Setup Helm - uses: azure/setup-helm@v3 + uses: azure/setup-helm@v4 + with: + token: ${{ github.token }} - name: Setup Kubectl - uses: Azure/setup-kubectl@v3 + uses: Azure/setup-kubectl@v4 + with: + token: ${{ github.token }} - name: deploy run: | kubectl config set-cluster k8s --server="${{ secrets.k8s_server }}" diff --git a/.github/workflows/openapi-generate-javascript-client.yaml b/.github/workflows/openapi-generate-javascript-client.yaml index e971c8d..0115738 100644 --- a/.github/workflows/openapi-generate-javascript-client.yaml +++ b/.github/workflows/openapi-generate-javascript-client.yaml @@ -108,7 +108,7 @@ jobs: message: "${{ steps.spec.outputs.title }} ${{ steps.spec.outputs.version }}" tag: ${{ steps.spec.outputs.version }} - name: Node Setup - uses: actions/setup-node@v4 + uses: actions/setup-node@v5 - run: npm install - run: npm run build - uses: JS-DevTools/npm-publish@v1 diff --git a/.github/workflows/openapi-generate-typescript-client.yaml b/.github/workflows/openapi-generate-typescript-client.yaml index c2b8617..a7f0969 100644 --- a/.github/workflows/openapi-generate-typescript-client.yaml +++ b/.github/workflows/openapi-generate-typescript-client.yaml @@ -108,7 +108,7 @@ jobs: message: "${{ steps.spec.outputs.title }} ${{ steps.spec.outputs.version }}" tag: ${{ steps.spec.outputs.version }} - name: Node Setup - uses: actions/setup-node@v4 + uses: actions/setup-node@v5 - run: npm install - run: npm run build - uses: JS-DevTools/npm-publish@v1