Bump Nullean.ScopedFileSystem to 0.4.0; use InnerType for mock detection

0.4.0 exposes ScopedFileSystem.InnerType, removing the need to check
the outer wrapper's type name when inspecting the underlying filesystem.

FileSystemFactory.BuildWriteOptions: use sf.InnerType where the inner FS
is available through a ScopedFileSystem to check for MockFileSystem, with
a note linking to the upstream fix PR
(TestableIO/System.IO.Abstractions#1454).

GitCheckoutInformation.Create: replace fileSystem.GetType().Name.Contains("Mock")
with (fileSystem is ScopedFileSystem sf ? sf.InnerType : fileSystem.GetType())
so the check correctly sees through the ScopedFileSystem wrapper.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <[email protected]>

Author: Mpdreamz

Directory.Packages.props

@@ -42,7 +42,7 @@
     <PackageVersion Include="Microsoft.Extensions.Configuration.UserSecrets" Version="10.0.0" />
     <PackageVersion Include="Microsoft.Extensions.Configuration.Abstractions" Version="10.0.3" />
     <PackageVersion Include="Microsoft.Extensions.Telemetry.Abstractions" Version="10.0.0" />
-    <PackageVersion Include="Nullean.ScopedFileSystem" Version="0.2.0" />
+    <PackageVersion Include="Nullean.ScopedFileSystem" Version="0.4.0" />
     <PackageVersion Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.13.0" />
     <PackageVersion Include="Generator.Equals" Version="3.3.0" PrivateAssets="all" IncludeAssets="runtime; build; native; contentfiles; analyzers; buildtransitive" />
     <PackageVersion Include="KubernetesClient" Version="18.0.5" />

src/Elastic.Documentation.Configuration/FileSystemFactory.cs

@@ -102,13 +102,23 @@ public static ScopedFileSystem ScopeCurrentWorkingDirectory(IFileSystem inner, I
 	}
 
 	// Builds write options that include AllowedSpecialFolders.Temp PLUS the inner FS's own
-	// GetTempPath() as an explicit root. This is necessary because MockFileSystem on non-Windows
-	// returns a hardcoded Unix-ified path ("/temp/") instead of System.IO.Path.GetTempPath(),
-	// causing a mismatch with the AllowedSpecialFolder.Temp validation which uses the real API.
+	// GetTempPath() as an explicit root — but only when the inner FS is MockFileSystem.
+	//
+	// On non-Windows MockFileSystem hardcodes a Unix-ified path ("/temp/", derived from "C:\temp")
+	// instead of calling System.IO.Path.GetTempPath(). AllowedSpecialFolder.Temp uses the real
+	// GetTempPath() (e.g. "/tmp/" on Linux), so the two diverge and scope validation fails for any
+	// path created via mockFs.Path.GetTempPath().
+	//
+	// Fix tracked upstream: https://github.com/TestableIO/System.IO.Abstractions/pull/1454
+	// Once that ships and we update the package reference we can drop this workaround.
+	//
+	// We use ScopedFileSystem.InnerType (added in Nullean.ScopedFileSystem 0.4.0) to avoid a
+	// fragile string-based type check.
 	private static ScopedFileSystemOptions BuildWriteOptions(IFileSystem inner, params string[] roots)
 	{
 		var allRoots = roots.ToList();
-		if (!OperatingSystem.IsWindows())
+		var innerType = inner is ScopedFileSystem sf ? sf.InnerType : inner.GetType();
+		if (!OperatingSystem.IsWindows() && innerType.Name.Contains("Mock", StringComparison.OrdinalIgnoreCase))
 		{
 			// Cover MockFileSystem's unixified hardcoded temp path
 			var innerTemp = inner.Path.GetTempPath().TrimEnd(Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar);

src/Elastic.Documentation/GitCheckoutInformation.cs

@@ -7,6 +7,7 @@
 using System.Text.RegularExpressions;
 using Elastic.Documentation.Extensions;
 using Microsoft.Extensions.Logging;
+using Nullean.ScopedFileSystem;
 using SoftCircuits.IniFileParser;
 
 namespace Elastic.Documentation;
@@ -45,9 +46,11 @@ public static GitCheckoutInformation Create(IDirectoryInfo? source, IFileSystem
 		if (source is null)
 			return Unavailable;
 
-		// Return test data for in-memory (mock) file systems. ScopedFileSystem wraps the real
-		// FileSystem so we check if the FS implementation name indicates an in-memory mock.
-		if (fileSystem.GetType().Name.Contains("Mock", StringComparison.OrdinalIgnoreCase))
+		// Return test data for in-memory (mock) file systems. Use ScopedFileSystem.InnerType
+		// (available since Nullean.ScopedFileSystem 0.4.0) to inspect through the scope wrapper
+		// rather than relying on the outer type name.
+		var fsType = fileSystem is ScopedFileSystem sf ? sf.InnerType : fileSystem.GetType();
+		if (fsType.Name.Contains("Mock", StringComparison.OrdinalIgnoreCase))
 		{
 			return new GitCheckoutInformation
 			{