From fcc175d0d9f1ad2a68e961c9c3bf36ff7b2e860c Mon Sep 17 00:00:00 2001 From: jianjun Date: Thu, 21 May 2026 19:58:19 +0200 Subject: [PATCH 1/6] Remove StringLiteral from mw/log - Remove string_literal dependency from mw/log GIT_ORIGIN_SPP_REV_ID: 0265646551b42ab8c6ced0729298cd497bd71b55 From 102a27b8aae29e594202450486772e7cd91a899b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20B=C3=A4uerle?= Date: Fri, 5 Jun 2026 13:53:06 +0200 Subject: [PATCH 2/6] common: migrate visitor & serialization to @score_baselibs Use the implementation in score_baselibs and delete it from spp. GIT_ORIGIN_SPP_REV_ID: f4abc30c1e257cd76948aa063dd7f929d8ee4a34 From abce72464e5fa71ea9f387414799a75026e46344 Mon Sep 17 00:00:00 2001 From: Xavier Bonaventura Date: Mon, 8 Jun 2026 22:30:19 +0200 Subject: [PATCH 3/6] Replace custom optional and string_view for standard ones GIT_ORIGIN_SPP_REV_ID: e03524de20aa62d1975be2260992b317fb322f04 From f961d4555b1c33d17a2354ee87da5f1c97ae1b06 Mon Sep 17 00:00:00 2001 From: jianjun Date: Sun, 7 Jun 2026 04:02:38 +0200 Subject: [PATCH 4/6] Move datarouterconf to log_and_trace/datarouterconf GIT_ORIGIN_SPP_REV_ID: 3becb088f47af50760e0c16bf5b1824c1a652030 --- score/datarouter/BUILD | 6 +++--- score/datarouter/build_configuration_flags/BUILD | 2 +- score/datarouter/dlt_filetransfer_trigger_lib/BUILD | 4 ++-- score/datarouter/test/ut/etc/BUILD | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/score/datarouter/BUILD b/score/datarouter/BUILD index 2b3e408d..8a986a39 100644 --- a/score/datarouter/BUILD +++ b/score/datarouter/BUILD @@ -72,7 +72,7 @@ cc_library( features = COMPILER_WARNING_FEATURES, strip_include_prefix = "include", visibility = [ - "//platform/aas/pas/datarouterconf:__subpackages__", + "//platform/aas/log_and_trace/datarouterconf:__subpackages__", "@score_logging//score/datarouter:__subpackages__", ], deps = [ @@ -290,7 +290,7 @@ cc_library( features = COMPILER_WARNING_FEATURES, strip_include_prefix = "include/daemon", visibility = [ - "//platform/aas/pas/datarouterconf:__subpackages__", + "//platform/aas/log_and_trace/datarouterconf:__subpackages__", ], ) @@ -350,7 +350,7 @@ cc_library( "include/daemon/configurator_commands.h", ], visibility = [ - "//platform/aas/pas/datarouterconf:__subpackages__", + "//platform/aas/log_and_trace/datarouterconf:__subpackages__", "@score_logging//score/datarouter:__subpackages__", ], ) diff --git a/score/datarouter/build_configuration_flags/BUILD b/score/datarouter/build_configuration_flags/BUILD index 5d51914d..ef556c25 100644 --- a/score/datarouter/build_configuration_flags/BUILD +++ b/score/datarouter/build_configuration_flags/BUILD @@ -24,7 +24,7 @@ config_setting( ":persistent_logging": "True", }, visibility = [ - "//platform/aas/pas/datarouterconf:__subpackages__", + "//platform/aas/log_and_trace/datarouterconf:__subpackages__", "@score_logging//score/datarouter:__subpackages__", ], ) diff --git a/score/datarouter/dlt_filetransfer_trigger_lib/BUILD b/score/datarouter/dlt_filetransfer_trigger_lib/BUILD index 20077d18..a654d5c2 100644 --- a/score/datarouter/dlt_filetransfer_trigger_lib/BUILD +++ b/score/datarouter/dlt_filetransfer_trigger_lib/BUILD @@ -27,8 +27,8 @@ cc_library( ], features = COMPILER_WARNING_FEATURES, visibility = [ + "//platform/aas/log_and_trace/datarouterconf/src/services:__pkg__", "//platform/aas/pas/crash_handler:__pkg__", - "//platform/aas/pas/datarouterconf/src/services:__pkg__", "//platform/aas/test/pas:__subpackages__", "//score/datarouter/test:__subpackages__", "//score/test/component:__subpackages__", @@ -49,8 +49,8 @@ cc_library( ], features = COMPILER_WARNING_FEATURES, visibility = [ + "//platform/aas/log_and_trace/datarouterconf/src/filetransfer:__subpackages__", "//platform/aas/pas/crash_handler:__subpackages__", - "//platform/aas/pas/datarouterconf/src/filetransfer:__subpackages__", "//score/mw/log/legacy_non_verbose_api:__pkg__", "@score_logging//score/datarouter:__subpackages__", ], diff --git a/score/datarouter/test/ut/etc/BUILD b/score/datarouter/test/ut/etc/BUILD index 098ef88e..9fe118dc 100644 --- a/score/datarouter/test/ut/etc/BUILD +++ b/score/datarouter/test/ut/etc/BUILD @@ -23,7 +23,7 @@ filegroup( "datarouter/persistent-logging_test_6.json", ], visibility = [ - "//platform/aas/pas/datarouterconf:__subpackages__", + "//platform/aas/log_and_trace/datarouterconf:__subpackages__", "@score_logging//score/datarouter:__subpackages__", ], ) From 8da19c3c1158c1de7adfac00cc5b694a3fcd86f3 Mon Sep 17 00:00:00 2001 From: rahul thakre Date: Tue, 16 Jun 2026 11:23:43 +0530 Subject: [PATCH 5/6] pas/logging: fix include pthread.h header & remove forward decl - include pthread OS wrapper in socketserver public header to avoid incomplete bmw::os::Pthread type usage - remove pthread forward declaration - Avoid using forward declaration and use include instead This is in line with Google's c++ stype guide https://google.github.io/styleguide/cppguide.html#Forward_Declarations GIT_ORIGIN_SPP_REV_ID: 6fe6742932aa487a83909e896a3c1d440c3f66dd --- score/datarouter/include/daemon/socketserver.h | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/score/datarouter/include/daemon/socketserver.h b/score/datarouter/include/daemon/socketserver.h index dd21ad9c..cebc079c 100644 --- a/score/datarouter/include/daemon/socketserver.h +++ b/score/datarouter/include/daemon/socketserver.h @@ -17,6 +17,7 @@ #include "daemon/dlt_log_server.h" #include "daemon/message_passing_server.h" #include "logparser/i_log_parser_factory.h" +#include "score/os/pthread.h" #include "score/mw/log/configuration/nvconfig.h" #include "score/mw/log/logging.h" #include "score/datarouter/datarouter/data_router.h" @@ -44,14 +45,6 @@ class ConnectMessageFromClient; } // namespace mw } // namespace score -namespace score -{ -namespace os -{ -class Pthread; -} // namespace os -} // namespace score - #include "score/message_passing/client_factory.h" #include "score/message_passing/server_factory.h" From 300edf90e14a95f7d8c796c05da36b22f1154c38 Mon Sep 17 00:00:00 2001 From: Xavier Bonaventura Date: Thu, 18 Jun 2026 11:10:50 +0200 Subject: [PATCH 6/6] mw: Treat all warnings as errors GIT_ORIGIN_SPP_REV_ID: ed8f4b89eb299614fdc773d1e62c18e50e8184b8 --- score/mw/common_features.bzl | 1 - 1 file changed, 1 deletion(-) diff --git a/score/mw/common_features.bzl b/score/mw/common_features.bzl index c46c86fb..3c5175a4 100644 --- a/score/mw/common_features.bzl +++ b/score/mw/common_features.bzl @@ -14,5 +14,4 @@ COMPILER_WARNING_FEATURES = [ "treat_warnings_as_errors", "additional_warnings", "strict_warnings", - "strict_warnings_no_error", ]