If I use the client.promoteBuild method with parameters then these are not available when the build executes.
It appears the root cause of this is that code at https://github.com/drone/drone-node/blob/master/lib/index.js#L331-L339 passes the parameters as part of the POST body, but the server expects them in the querystring (based on my reading of https://docs.drone.io/api/builds/build_promote/)
I tried making the same requests with curl to validate this and if the params are sent in the query string then they appear correctly.
I would make this change myself since it should be fairly simple, but I don't know the API well enough to know which other methods are affected (I suspect there may be several).
If I use the
client.promoteBuildmethod with parameters then these are not available when the build executes.It appears the root cause of this is that code at https://github.com/drone/drone-node/blob/master/lib/index.js#L331-L339 passes the parameters as part of the POST body, but the server expects them in the querystring (based on my reading of https://docs.drone.io/api/builds/build_promote/)
I tried making the same requests with
curlto validate this and if the params are sent in the query string then they appear correctly.I would make this change myself since it should be fairly simple, but I don't know the API well enough to know which other methods are affected (I suspect there may be several).